Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scala Common Enrich: make IpLookupsEnrichment failure message more informative #1426

Closed
fblundun opened this issue Feb 16, 2015 · 2 comments
Closed

Scala Common Enrich: make IpLookupsEnrichment failure message more informative #1426

fblundun opened this issue Feb 16, 2015 · 2 comments
Assignees
@fblundun
Labels
3. Enrich
Milestone
Release 66 Orient...

Comments

@fblundun
Copy link
Contributor

Here: https://github.com/snowplow/snowplow/blob/master/3-enrich/scala-common-enrich/src/main/scala/com.snowplowanalytics.snowplow.enrich/common/enrichments/registry/IpLookupsEnrichment.scala#L204

The original exception should be in the failure message.
@alexanderdean
Copy link
Member

Good thinking

@fblundun fblundun self-assigned this May 27, 2015
@fblundun fblundun added this to the Release 66 Oriental Skylark milestone May 27, 2015
@alexanderdean alexanderdean changed the title Make IpLookupsEnrichment failure message more informative Scala Common Enrich: make IpLookupsEnrichment failure message more informative May 27, 2015
@alexanderdean
Copy link
Member

Please do this into this branch: https://github.com/snowplow/snowplow/tree/feature/r66-common-enrich

fblundun added a commit that referenced this issue May 28, 2015
@fblundun
Scala Common Enrich: made IpLookupsEnrichment error message more info…
913c3a8 
…rmative (closes #1426)
fblundun added a commit that referenced this issue Jun 4, 2015
@fblundun @alexanderdean
Scala Common Enrich: made IpLookupsEnrichment error message more info…
95bdadd 
…rmative (closes #1426)
fblundun added a commit that referenced this issue Jun 4, 2015
@fblundun @alexanderdean
Scala Common Enrich: made IpLookupsEnrichment error message more info…
8a23e2d 
…rmative (closes #1426)
fblundun added a commit that referenced this issue Jun 30, 2015
@fblundun @alexanderdean
Scala Common Enrich: made IpLookupsEnrichment error message more info…
7b1811e 
…rmative (closes #1426)
alexanderdean pushed a commit that referenced this issue Jan 14, 2016
@fblundun @alexanderdean
Scala Common Enrich: made IpLookupsEnrichment error message more info…
e487a78 
…rmative (closes #1426)
oguzhanunlu pushed a commit to snowplow/common-enrich that referenced this issue May 29, 2020
@fblundun @alexanderdean
Made IpLookupsEnrichment error message more informative (closes snowp…
1f6a3b1 
…low/snowplow#1426)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fblundun fblundun

Labels
3. Enrich
Projects
None yet
Milestone
Release 66 Oriental Skylark
Development

No branches or pull requests
2 participants
@alexanderdean @fblundun