Scala Common Enrich: etl_tstamp in Enrichment Manager should be a Joda DateTime not a String

[jbeemster]

No description provided.

[alexanderdean]

Pushing back to R69

[alexanderdean]

This will ensure better type safety...

[fblundun]

The nice thing about keeping this a String rather than a DateTime in the EnrichmentManager is that it means we don't need to convert the DateTime to a Redshift-compatible string with every event we process.

Instead we could make EtlPipeline a class rather than an object and give it a constructor with a DateTime etlTstamp parameter.

[alexanderdean]

Hmm - how would the EtlPipeline as a class sit with Kinesis Enrich? Given that the output for Common Enrich won't be Redshift-formatted in a few releases' time anyway, I'm not too stressed about the conversion (in other words, soon we will have lots of conversions anyway).

[fblundun]

With Kinesis Enrich you would create a new EtlPipeline with a new timestamp (or update the timestamp of the existing EtlPipeline) for every call to GetRecords.

But proportionally, the effect on performance should be pretty small, so maybe we just make it a DateTime and do the conversion in each call to enrichEvent.

[alexanderdean]

Thanks for clarifying - yep - I think let's just make it a DateTime...