Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE 8 bug: page ping functionality not working #260

Closed
alexanderdean opened this issue May 21, 2013 · 6 comments
Closed

IE 8 bug: page ping functionality not working #260

alexanderdean opened this issue May 21, 2013 · 6 comments
Assignees
Milestone

Comments

@alexanderdean
Copy link
Member

Yali to add details.

Alex to fix.

@ghost ghost assigned yalisassoon May 21, 2013
@yalisassoon
Copy link
Member

IE Version 8.0.7601.17514

Error message:

'pageXOffset' is undefined
sp.js
Code: 0
URI: https://d2zn5qkst6mwpf.cloudfront.net/sp.js

@alexanderdean
Copy link
Member Author

Where can I download a VM from with IE8?

@yalisassoon
Copy link
Member

Issue appears on at least two different websites with enableActivityTracking (so not a site specific issue)

@ghost ghost assigned alexanderdean Jul 6, 2013
@alexanderdean
Copy link
Member Author

Problem looks to be this code:

var x = offsets[0];
if (pageXOffset < minXOffset) {
    minXOffset = pageXOffset;
} else if (pageXOffset > maxXOffset) {
    maxXOffset = pageXOffset;
}

var y = offsets[1];
if (pageYOffset < minYOffset) {
    minYOffset = pageYOffset;
} else if (pageYOffset > maxYOffset) {
    maxYOffset = pageYOffset;
}

This code should be making use of the x and y variables. Referring to pageXOffset and pageYOffset will error on any browser that doesn't have these as properties of the window object.

alexanderdean added a commit that referenced this issue Jul 7, 2013
@alexanderdean
Copy link
Member Author

Implemented as part of 0.8.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants