Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala Common Enrich: support IPv6 addresses in the IpAddressExtractor #3474

Closed
miike opened this issue Oct 22, 2017 · 0 comments
Closed

Scala Common Enrich: support IPv6 addresses in the IpAddressExtractor #3474

miike opened this issue Oct 22, 2017 · 0 comments
Assignees

Comments

@miike
Copy link
Contributor

miike commented Oct 22, 2017

Currently the IpAddressExtractor performs an extract using the following regular expression

^x-forwarded-for: ((?:[0-9]|\.)+).*

If an IPv6 address occurs in the leftmost position in the X-Forwarded-For header this will result in a concatenated IP address. This can be fixed by allowing the x-forwarded-for regular expression to match additional alphabetic and separator : characters.

miike pushed a commit to poplindata/snowplow that referenced this issue Oct 25, 2017
@BenFradet BenFradet changed the title Scala Common Enrich: Support IPv6 addresses in the IpAddressExtractor Scala Common Enrich: support IPv6 addresses in the IpAddressExtractor Apr 4, 2018
@BenFradet BenFradet self-assigned this Apr 17, 2018
oguzhanunlu pushed a commit to snowplow/common-enrich that referenced this issue May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants