Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scala Common Enrich: extend PII Enrichment to include identification events in EnrichedEvent #3580

Closed
alexanderdean opened this issue Jan 16, 2018 · 8 comments
Closed

Scala Common Enrich: extend PII Enrichment to include identification events in EnrichedEvent #3580

alexanderdean opened this issue Jan 16, 2018 · 8 comments
Assignees
@BenFradet @knservis
Milestone
R106 Acropolis (P...

Comments

@alexanderdean
Copy link
Member

No description provided.

@alexanderdean alexanderdean added this to the GDPR support pt.2 milestone Jan 16, 2018
@alexanderdean alexanderdean changed the title Scala Common Enrich: extend PII Enrichment to xxx Scala Common Enrich: extend PII Enrichment to XXX [Kostas to update] Jan 16, 2018
@alexanderdean alexanderdean removed their assignment Jan 16, 2018
@alexanderdean alexanderdean mentioned this issue Jan 16, 2018
Closed
@alexanderdean
Copy link
Member Author

The name of this ticket needs a bit of work, or we might split it into two tickets.

@knservis knservis changed the title Scala Common Enrich: extend PII Enrichment to XXX [Kostas to update] Scala Common Enrich: extend PII Enrichment to include identification events in EnrichedEvent Jan 16, 2018
@knservis
Copy link
Contributor

@alexanderdean Does that name capture the work?

@alexanderdean
Copy link
Member Author

alexanderdean commented Jan 16, 2018 •
edited

Yep I think that's good for now. We'll probably want to box around EnrichedEvent in due course, as that envelope will technically contain multiple enriched events now.

knservis added a commit that referenced this issue Jan 17, 2018
@knservis
Scala Common Enrich: extend PII Enrichment to include identification …
043e638 
…events in EnrichedEvent (closes #3580)
knservis added a commit that referenced this issue Jan 31, 2018
@knservis
Scala Common Enrich: extend PII Enrichment to include identification …
6c87d3a 
…events in EnrichedEvent (closes #3580)
@knservis
Copy link
Contributor

Depends on snowplow/iglu-central#708

This was referenced Feb 7, 2018
Closed
Closed
knservis added a commit that referenced this issue Feb 13, 2018
@knservis
Scala Common Enrich: extend PII Enrichment to include identification …
a3ff4c7 
…events in EnrichedEvent (closes #3580)
knservis added a commit that referenced this issue Feb 14, 2018
@knservis
Scala Common Enrich: extend PII Enrichment to include identification …
adf03cf 
…events in EnrichedEvent (closes #3580)
knservis added a commit that referenced this issue Feb 14, 2018
@knservis
Scala Common Enrich: extend PII Enrichment to include identification …
79833af 
…events in EnrichedEvent (closes #3580)
knservis added a commit that referenced this issue Feb 16, 2018
@knservis
Scala Common Enrich: extend PII Enrichment to include identification …
bf339af 
…events in EnrichedEvent (closes #3580)
knservis added a commit that referenced this issue Feb 16, 2018
@knservis
Scala Common Enrich: extend PII Enrichment to include identification …
2d6d9d2 
…events in EnrichedEvent (closes #3580)
knservis added a commit that referenced this issue Feb 20, 2018
@knservis
Scala Common Enrich: extend PII Enrichment to include identification …
522baa8 
…events in EnrichedEvent (closes #3580)
knservis added a commit that referenced this issue Feb 20, 2018
@knservis
Scala Common Enrich: extend PII Enrichment to include identification …
40a70ea 
…events in EnrichedEvent (closes #3580)
knservis added a commit that referenced this issue Feb 21, 2018
@knservis
Scala Common Enrich: extend PII Enrichment to include identification …
1abfa45 
…events in EnrichedEvent (closes #3580)
knservis added a commit that referenced this issue Feb 21, 2018
@knservis
Scala Common Enrich: extend PII Enrichment to include identification …
187e5eb 
…events in EnrichedEvent (closes #3580)
knservis added a commit that referenced this issue Feb 21, 2018
@knservis
Scala Common Enrich: extend PII Enrichment to include identification …
e4e4dab 
…events in EnrichedEvent (closes #3580)
@knservis knservis mentioned this issue Feb 22, 2018
Merged
7 tasks
knservis added a commit that referenced this issue Feb 23, 2018
@knservis
Scala Common Enrich: extend PII Enrichment to include identification …
a603cd4 
…events in EnrichedEvent (closes #3580)
knservis added a commit that referenced this issue Feb 26, 2018
@knservis
Scala Common Enrich: extend PII Enrichment to include identification …
ef9c8b3 
…events in EnrichedEvent (closes #3580)
knservis added a commit that referenced this issue Mar 1, 2018
@knservis
Scala Common Enrich: extend PII Enrichment to include identification …
e424352 
…events in EnrichedEvent (closes #3580)
@knservis
Copy link
Contributor

knservis commented Mar 2, 2018

@alexanderdean @yalisassoon Before releasing part 2 we may want to consider emitting a salt if it is finally added (We will need to modify iglu-central schemas for config and the event). See discussion here #3648
Should we hold off till we have made a decision?

knservis added a commit that referenced this issue Mar 2, 2018
@knservis
Scala Common Enrich: extend PII Enrichment to include identification …
9bc6325 
…events in EnrichedEvent (closes #3580)
knservis added a commit that referenced this issue Mar 2, 2018
@knservis
Scala Common Enrich: extend PII Enrichment to include identification …
553e069 
…events in EnrichedEvent (closes #3580)
@alexanderdean
Copy link
Member Author

Hey @knservis - what do you mean by

emitting a salt

Surely the salt should be very closely held?

@alexanderdean
Copy link
Member Author

BTW I've scheduled #3648

@knservis
Copy link
Contributor

knservis commented Mar 5, 2018

@alexanderdean Yes the salt should not be emitted. It should only be in config.

knservis added a commit that referenced this issue Mar 5, 2018
@knservis
Scala Common Enrich: extend PII Enrichment to include identification …
a46b772 
…events in EnrichedEvent (closes #3580)
@knservis knservis mentioned this issue Mar 6, 2018
Closed
knservis added a commit that referenced this issue Mar 21, 2018
@knservis
FIXUP Scala Common Enrich: extend PII Enrichment to include idntifica…
88fd26b 
…tion events in EnrichedEvent (closes #3580)
knservis added a commit that referenced this issue Mar 23, 2018
@knservis
Scala Common Enrich: extend PII Enrichment to include identification …
c65f464 
…events in EnrichedEvent (closes #3580)
knservis added a commit that referenced this issue Apr 23, 2018
@knservis
Scala Common Enrich: extend PII Enrichment to include identification …
37911e0 
…events in EnrichedEvent (closes #3580)
knservis added a commit that referenced this issue May 10, 2018
@knservis
Scala Common Enrich: extend PII Enrichment to include identification …
925ef51 
…events in EnrichedEvent (closes #3580)
knservis added a commit that referenced this issue May 23, 2018
@knservis
Scala Common Enrich: extend PII Enrichment to include identification …
6833fc6 
…events in EnrichedEvent (closes #3580)
knservis added a commit that referenced this issue May 23, 2018
@knservis
Scala Common Enrich: extend PII Enrichment to include identification …
31f331b 
…events in EnrichedEvent (closes #3580)
knservis added a commit that referenced this issue May 23, 2018
@knservis
Scala Common Enrich: extend PII Enrichment to include identification …
cffb11b 
…events in EnrichedEvent (closes #3580)
knservis added a commit that referenced this issue May 23, 2018
@knservis
Scala Common Enrich: extend PII Enrichment to include identification …
ebfa238 
…events in EnrichedEvent (closes #3580)
knservis added a commit that referenced this issue May 25, 2018
@knservis
Scala Common Enrich: extend PII Enrichment to include identification …
009b6d7 
…events in EnrichedEvent (closes #3580)
knservis added a commit that referenced this issue May 25, 2018
@knservis
Scala Common Enrich: extend PII Enrichment to include identification …
ceb5cde 
…events in EnrichedEvent (closes #3580)
knservis added a commit that referenced this issue Jun 6, 2018
@knservis
Scala Common Enrich: extend PII Enrichment to include identification …
7c270a1 
…events in EnrichedEvent (closes #3580)
knservis added a commit that referenced this issue Jun 6, 2018
@knservis
Scala Common Enrich: extend PII Enrichment to include identification …
6747c21 
…events in EnrichedEvent (closes #3580)
knservis added a commit that referenced this issue Jun 14, 2018
@knservis
Scala Common Enrich: extend PII Enrichment to include identification …
90c7f7a 
…events in EnrichedEvent (closes #3580)
BenFradet pushed a commit that referenced this issue Jun 14, 2018
@knservis @BenFradet
Scala Common Enrich: extend PII Enrichment to include identification …
a332ddc 
…events in EnrichedEvent (closes #3580)
oguzhanunlu pushed a commit to snowplow/common-enrich that referenced this issue May 29, 2020
@knservis @oguzhanunlu
Extend PII Enrichment to include identification events in EnrichedEve…
2e8fd91 
…nt (closes snowplow/snowplow#3580)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenFradet BenFradet

@knservis knservis

Labels
None yet
Projects
None yet
Milestone
R106 Acropolis (PII Enrichment pt.2)
Development

No branches or pull requests
3 participants
@alexanderdean @BenFradet @knservis