Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream Enrich: fix parent event context in PII events #3886

Closed
knservis opened this issue Aug 30, 2018 · 3 comments
Closed

Stream Enrich: fix parent event context in PII events #3886

knservis opened this issue Aug 30, 2018 · 3 comments

Comments

@knservis
Copy link
Contributor

knservis commented Aug 30, 2018 •
edited

Project: Stream Enrich

Version: R109

Expected behavior: PII event contexts contains valid iglu schema

Actual behavior: PII event does not contain valid iglu schema

Steps to reproduce:
Run Stream enrich and observe the PII events (look in the contexts[0].schema)

The bug is here:

snowplow/3-enrich/stream-enrich/core/src/main/scala/com.snowplowanalytics.snowplow.enrich.stream/sources/Source.scala

Line 145 in d8f028f

("schema" -> "com.snowplowanalytics.snowplow/parent_event/jsonschema/1-0-0") ~ ("data" -> ("parentEventId" -> eventId)))))

As an aside, I am moving all snake case constants to object Source and naming as per: https://docs.scala-lang.org/style/naming-conventions.html)
@knservis knservis added the bug label Aug 30, 2018
@alexanderdean
Copy link
Member

Ouch. How did this slip through?

@chuwy
Copy link
Contributor

chuwy commented Aug 30, 2018 •
edited

By not containing valid schema, do you mean that it misses iglu: prefix?

@knservis
Copy link
Contributor Author

knservis commented Aug 30, 2018 •
edited

Yes @chuwy

@alexanderdean I know..

knservis added a commit that referenced this issue Aug 30, 2018
@knservis
Stream Enrich: fix parent event context in PII events (close #3886)
4ae14f8
knservis added a commit that referenced this issue Aug 31, 2018
@knservis
Stream Enrich: fix parent event context in PII events (close #3886)
c921fec
BenFradet pushed a commit that referenced this issue Aug 31, 2018
@knservis @BenFradet
Stream Enrich: fix parent event context in PII events (close #3886)
4b69e13
BenFradet pushed a commit that referenced this issue Aug 31, 2018
@knservis @BenFradet
Stream Enrich: fix parent event context in PII events (close #3886)
d5588b6
BenFradet pushed a commit that referenced this issue Sep 3, 2018
@knservis @BenFradet
Stream Enrich: fix parent event context in PII events (close #3886)
5dc53ca
BenFradet pushed a commit that referenced this issue Sep 4, 2018
@knservis @BenFradet
Stream Enrich: fix parent event context in PII events (close #3886)
120094a
BenFradet pushed a commit that referenced this issue Sep 4, 2018
@knservis @BenFradet
Stream Enrich: fix parent event context in PII events (close #3886)
aeebe0e
BenFradet pushed a commit that referenced this issue Sep 4, 2018
@knservis @BenFradet
Stream Enrich: fix parent event context in PII events (close #3886)
354e93d
BenFradet pushed a commit that referenced this issue Sep 6, 2018
@knservis @BenFradet
Stream Enrich: fix parent event context in PII events (close #3886)
4b09562
oguzhanunlu pushed a commit to snowplow/stream-enrich that referenced this issue May 28, 2020
@knservis @oguzhanunlu
Fix parent event context in PII events (close snowplow/snowplow#3886)
4cd4532
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexanderdean @chuwy @knservis