-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scala Common Enrich: separate EnrichmentRegistry parsing from its construction #4033
Comments
can we have step3 produce |
I added |
That's okay. At least I will use the result of this issue for my issue. It would be ways more straight-forward. |
oguzhanunlu
pushed a commit
to snowplow/common-enrich
that referenced
this issue
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
the workflow for an enrichment platform should be:
Json -> F[List[EnrichmentConf]]
(enrichment configs contain the files to cache)List[EnrichmentConf] -> F[Unit]
orUnit
, this is up to the enricherEnrichmentRegistry
:List[EnrichmentConf] -> F[List[Enrichment]]
List[Enrichment] -> F[List[EnrichedEvent]]
We need to separate parsing from construction because some enrichments' constructions are side-effectful, for example referer parser which reads a file
The text was updated successfully, but these errors were encountered: