Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beam Enrich: fix unit tests failing after update of MaxMind database #4129

Closed
dilyand opened this issue Sep 3, 2019 · 1 comment
Closed
Assignees

Comments

@dilyand
Copy link
Contributor

dilyand commented Sep 3, 2019

Whenever a new version of the Maxmind DB for ip lookups is uploaded to the hosted assets bucket, the EnrichWithLocalFileSpec test in Beam Enrich can start failing if the data points associated with the IP address used in it have changed.

@alexanderdean
Copy link
Member

There are some root IPs in the database that never change, suggest using those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants