Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scala Common Enrich: wrap all contexts and unstruct events into SelfDescribingData #4241

Closed
chuwy opened this issue Nov 11, 2019 · 1 comment
Closed

Scala Common Enrich: wrap all contexts and unstruct events into SelfDescribingData #4241

chuwy opened this issue Nov 11, 2019 · 1 comment
Assignees
@chuwy
Milestone
R118 Morgantina (...

Comments

@chuwy
Copy link
Contributor

chuwy commented Nov 11, 2019

I was fixing a flaky integration test for API Request enrichment and noticed that most of our JSON processing in EnrichmentManager is stringly-typed.
@chuwy chuwy self-assigned this Nov 11, 2019
chuwy added a commit that referenced this issue Nov 14, 2019
@chuwy
Scala Common Enrich: wrap all contexts and unstruct events into SelfD…
e1c7916 
…escribingData (close #4241)
chuwy added a commit that referenced this issue Nov 16, 2019
@chuwy
Scala Common Enrich: wrap all contexts and unstruct events into SelfD…
530a3ea 
…escribingData (close #4241)
chuwy added a commit that referenced this issue Nov 16, 2019
@chuwy
Scala Common Enrich: wrap all contexts and unstruct events into SelfD…
dc1ef8e 
…escribingData (close #4241)
@chuwy
Copy link
Contributor Author

chuwy commented Nov 16, 2019 •
edited

This ticket (which turned out to be more bloated than I expected) has one unexpected (but still desired) consequence in SQL Query enrichment. Previously when event and JSON inputs had clashing placeholders, event inputs always had a prioriity. Now clashing inputs prioritized by orders they were specified - last one wins.

chuwy added a commit that referenced this issue Nov 16, 2019
@chuwy
Scala Common Enrich: wrap all contexts and unstruct events into SelfD…
f00118c 
…escribingData (close #4241)
chuwy added a commit that referenced this issue Nov 16, 2019
@chuwy
Scala Common Enrich: wrap all contexts and unstruct events into SelfD…
9752c67 
…escribingData (close #4241)
chuwy added a commit that referenced this issue Nov 16, 2019
@chuwy
Scala Common Enrich: wrap all contexts and unstruct events into SelfD…
800d141 
…escribingData (close #4241)
chuwy added a commit that referenced this issue Nov 17, 2019
@chuwy
Scala Common Enrich: wrap all contexts and unstruct events into SelfD…
5c05a3e 
…escribingData (close #4241)
chuwy added a commit that referenced this issue Nov 17, 2019
@chuwy
Scala Common Enrich: wrap all contexts and unstruct events into SelfD…
5e0a650 
…escribingData (close #4241)
chuwy added a commit that referenced this issue Nov 17, 2019
@chuwy
Scala Common Enrich: wrap all contexts and unstruct events into SelfD…
eb85e9d 
…escribingData (close #4241)
chuwy added a commit that referenced this issue Nov 17, 2019
@chuwy
Scala Common Enrich: wrap all contexts and unstruct events into SelfD…
2e546f6 
…escribingData (close #4241)
chuwy added a commit that referenced this issue Nov 17, 2019
@chuwy
Scala Common Enrich: wrap all contexts and unstruct events into SelfD…
c7ad08b 
…escribingData (close #4241)
chuwy added a commit that referenced this issue Nov 17, 2019
@chuwy
Scala Common Enrich: wrap all contexts and unstruct events into SelfD…
003faff 
…escribingData (close #4241)
chuwy added a commit that referenced this issue Nov 22, 2019
@chuwy
Scala Common Enrich: wrap all contexts and unstruct events into SelfD…
894d31d 
…escribingData (close #4241)
chuwy added a commit that referenced this issue Nov 23, 2019
@chuwy
Scala Common Enrich: wrap all contexts and unstruct events into SelfD…
afa6e4c 
…escribingData (close #4241)
benjben pushed a commit that referenced this issue Dec 4, 2019
@chuwy @benjben
Scala Common Enrich: wrap all contexts and unstruct events into SelfD…
11dacb3 
…escribingData (close #4241)
benjben pushed a commit that referenced this issue Dec 6, 2019
@chuwy @benjben
Scala Common Enrich: wrap all contexts and unstruct events into SelfD…
8f8a2b3 
…escribingData (close #4241)
benjben pushed a commit that referenced this issue Dec 9, 2019
@chuwy @benjben
Scala Common Enrich: wrap all contexts and unstruct events into SelfD…
a3aaa80 
…escribingData (close #4241)
benjben pushed a commit that referenced this issue Dec 9, 2019
@chuwy @benjben
Scala Common Enrich: wrap all contexts and unstruct events into SelfD…
567ded7 
…escribingData (close #4241)
benjben pushed a commit that referenced this issue Dec 12, 2019
@chuwy @benjben
Scala Common Enrich: wrap all contexts and unstruct events into SelfD…
a9dc542 
…escribingData (close #4241)
oguzhanunlu pushed a commit to snowplow/common-enrich that referenced this issue May 29, 2020
@chuwy @oguzhanunlu
Wrap all contexts and unstruct events into SelfDescribingData (close s…
31b5ea7 
…nowplow/snowplow#4241)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chuwy chuwy

Labels
None yet
Projects
None yet
Milestone
R118 Morgantina (New bad row format)
Development

No branches or pull requests
1 participant
@chuwy