Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala Common Enrich: add ua-parser enrichment #62

Closed
alexanderdean opened this issue Oct 23, 2012 · 7 comments
Closed

Scala Common Enrich: add ua-parser enrichment #62

alexanderdean opened this issue Oct 23, 2012 · 7 comments
Assignees

Comments

@alexanderdean
Copy link
Member

The current useragent library takes an algorithm-based approach - there are other libraries out there which are based on a regularly updated 'database' (YAML) of useragent strings. We should move to one of these.

@yalisassoon
Copy link
Member

I think this is the library we should use: https://github.com/tobie/ua-parser
Master YAML is here: https://github.com/tobie/ua-parser/blob/master/regexes.yaml

@rcs
Copy link

rcs commented Aug 23, 2013

+1. Just wanted to pull a quick "Mobile vs non-mobile" device thing, and this was pretty sad with the exclusion of iOS.

What can be done to help move this forward?

@alexanderdean
Copy link
Member Author

To move this forward, someone needs to:

  1. Have a play with ua-parser
  2. Grok which fields ua-parser will generate
  3. Figure out how they map onto our existing fields - any renames, deletes, additions
  4. Add ua-parser as a dependency
  5. Remove the old library in hadoop-etl/lib
  6. Replace the old library code with ua-parser code
  7. Update the Redshift table definition
  8. Provide a migration script from old Redshift table definition to new one
  9. Update the Postgres table definition
  10. Provide a migration script from old Postgres table definition to new one
  11. Update the Analytics Cookbook recipes as appropriate

@kingo55
Copy link
Contributor

kingo55 commented Nov 16, 2013

For the interim, should we just move to the latest version of Useragent Utils (this is the one we're using right?)? They're up to 1.11 now and look to have fixed a number of things.

https://github.com/HaraldWalker/user-agent-utils

@alexanderdean
Copy link
Member Author

Hey @kingo55 - agreed, we'll do that in the next release: #416

@alexanderdean
Copy link
Member Author

@pkallos had a play around with this - see #576 for details. Unfortunately ua-parser takes away things (e.g. browserType), even as it gives us enhanced accuracy.

So rather than a direct replacement, maybe we leave till we have pluggable enrichments, and then we offer both different UA parsing options

@alexanderdean alexanderdean changed the title Change useragent library Add ua-parser enrichment Jun 2, 2014
@alexanderdean alexanderdean added this to the Useragent phase 2 milestone Jun 2, 2014
@alexanderdean
Copy link
Member Author

Ticket depends on: snowplow/iglu-central#96, snowplow/iglu-central#94

AALEKH added a commit to AALEKH/snowplow that referenced this issue Jan 4, 2015
AALEKH added a commit to AALEKH/snowplow that referenced this issue Jan 12, 2015
AALEKH added a commit to AALEKH/snowplow that referenced this issue Jan 14, 2015
AALEKH added a commit to AALEKH/snowplow that referenced this issue Jan 14, 2015
AALEKH added a commit to AALEKH/snowplow that referenced this issue Jan 14, 2015
AALEKH added a commit to AALEKH/snowplow that referenced this issue Jan 14, 2015
AALEKH added a commit to AALEKH/snowplow that referenced this issue Jan 14, 2015
Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)
@alexanderdean alexanderdean modified the milestones: Snowplow Core 2015 refresh, Aalekh milestone 1 Jan 14, 2015
AALEKH added a commit to AALEKH/snowplow that referenced this issue Jan 15, 2015
AALEKH added a commit to AALEKH/snowplow that referenced this issue Jan 15, 2015
Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)
AALEKH added a commit to AALEKH/snowplow that referenced this issue Jan 15, 2015
AALEKH added a commit to AALEKH/snowplow that referenced this issue Jan 15, 2015
AALEKH added a commit to AALEKH/snowplow that referenced this issue Jan 15, 2015
Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)
AALEKH added a commit to AALEKH/snowplow that referenced this issue Jan 16, 2015
AALEKH added a commit to AALEKH/snowplow that referenced this issue Jan 16, 2015
Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)
AALEKH added a commit to AALEKH/snowplow that referenced this issue Jan 16, 2015
AALEKH added a commit to AALEKH/snowplow that referenced this issue Jan 16, 2015
Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)
AALEKH added a commit to AALEKH/snowplow that referenced this issue Jan 21, 2015
AALEKH added a commit to AALEKH/snowplow that referenced this issue Jan 21, 2015
Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)
AALEKH added a commit to AALEKH/snowplow that referenced this issue Jan 21, 2015
AALEKH added a commit to AALEKH/snowplow that referenced this issue Jan 21, 2015
Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)
AALEKH added a commit to AALEKH/snowplow that referenced this issue Jan 21, 2015
AALEKH added a commit to AALEKH/snowplow that referenced this issue Jan 21, 2015
Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)
AALEKH added a commit to AALEKH/snowplow that referenced this issue Jan 21, 2015
AALEKH added a commit to AALEKH/snowplow that referenced this issue Jan 21, 2015
Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)

Added ua-parser enrichment (closes snowplow#62)
fblundun pushed a commit that referenced this issue Feb 5, 2015
Added ua-parser enrichment (closes #62)

Added ua-parser enrichment (closes #62)

Added ua-parser enrichment (closes #62)

Added ua-parser enrichment (closes #62)

Added ua-parser enrichment (closes #62)

Added ua-parser enrichment (closes #62)

Added ua-parser enrichment (closes #62)

Added ua-parser enrichment (closes #62)

Added ua-parser enrichment (closes #62)

Added ua-parser enrichment (closes #62)

Added ua-parser enrichment (closes #62)

Added ua-parser enrichment (closes #62)
fblundun pushed a commit that referenced this issue Mar 2, 2015
Added ua-parser enrichment (closes #62)

Added ua-parser enrichment (closes #62)

Added ua-parser enrichment (closes #62)

Added ua-parser enrichment (closes #62)

Added ua-parser enrichment (closes #62)

Added ua-parser enrichment (closes #62)

Added ua-parser enrichment (closes #62)

Added ua-parser enrichment (closes #62)

Added ua-parser enrichment (closes #62)

Added ua-parser enrichment (closes #62)

Added ua-parser enrichment (closes #62)

Added ua-parser enrichment (closes #62)
@fblundun fblundun changed the title Add ua-parser enrichment Scala Common Enrich: add ua-parser enrichment Mar 6, 2015
oguzhanunlu pushed a commit to snowplow/common-enrich that referenced this issue May 29, 2020
Added ua-parser enrichment (closes snowplow/snowplow#62)

Added ua-parser enrichment (closes snowplow/snowplow#62)

Added ua-parser enrichment (closes snowplow/snowplow#62)

Added ua-parser enrichment (closes snowplow/snowplow#62)

Added ua-parser enrichment (closes snowplow/snowplow#62)

Added ua-parser enrichment (closes snowplow/snowplow#62)

Added ua-parser enrichment (closes snowplow/snowplow#62)

Added ua-parser enrichment (closes snowplow/snowplow#62)

Added ua-parser enrichment (closes snowplow/snowplow#62)

Added ua-parser enrichment (closes snowplow/snowplow#62)

Added ua-parser enrichment (closes snowplow/snowplow#62)

Added ua-parser enrichment (closes snowplow/snowplow#62)
oguzhanunlu pushed a commit to snowplow/common-enrich that referenced this issue May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants