Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EmrEtlRunner: remove enrichment-specific arguments from EmrEtlRunner #808

Closed
alexanderdean opened this issue Jun 3, 2014 · 3 comments
Closed

EmrEtlRunner: remove enrichment-specific arguments from EmrEtlRunner #808

alexanderdean opened this issue Jun 3, 2014 · 3 comments
Assignees
@fblundun
Labels
3. Enrich
Milestone
Version 0.9.6

Comments

@alexanderdean
Copy link
Member

Rather than sending through e.g.

https://github.com/snowplow/snowplow/blob/master/3-enrich/emr-etl-runner/lib/snowplow-emr-etl-runner/emr_job.rb#L129

https://github.com/snowplow/snowplow/blob/master/3-enrich/emr-etl-runner/lib/snowplow-emr-etl-runner/emr_job.rb#L126

we need to just send through the full JSON itself.
@alexanderdean alexanderdean added this to the JSON-powered enrichments milestone Jun 3, 2014
@alexanderdean
Copy link
Member Author

As per: https://github.com/snowplow/snowplow/blob/feature/shredder/3-enrich/emr-etl-runner/lib/snowplow-emr-etl-runner/emr_job.rb#L186

fblundun added a commit that referenced this issue Jun 17, 2014
@fblundun
Removed enrichment-specific code from EmrEtlRunner (#811)
aad7fd0 
Replaced enrichment-specific args from Emr-EtlRunner -> Hadoop Enrich, replaced with enrichments JSON (#808)
fblundun added a commit that referenced this issue Jun 17, 2014
@fblundun
Removed enrichment-specific code from EmrEtlRunner (#811)
049ebda 
Replaced enrichment-specific args from Emr-EtlRunner -> Hadoop Enrich, replaced with enrichments JSON (#808)
fblundun added a commit that referenced this issue Jun 17, 2014
@fblundun
Removed enrichment-specific code from EmrEtlRunner (#811)
c2cd7ea 
Replaced enrichment-specific args from Emr-EtlRunner -> Hadoop Enrich, replaced with enrichments JSON (#808)
@alexanderdean alexanderdean changed the title Remove enrichment-specific args from EmrEtlRunner -> Hadoop Enrich, replace with enrichments JSON EmrEtlRunner: remove enrichment-specific arguments from EmrEtlRunner Jun 25, 2014
@alexanderdean
Copy link
Member Author

@fblundun update ticket name in CHANGELOG

fblundun added a commit that referenced this issue Jun 25, 2014
@fblundun
Removed enrichment-specific code from EmrEtlRunner (#811)
a433d23 
Replaced enrichment-specific args from Emr-EtlRunner -> Hadoop Enrich, replaced with enrichments JSON (#808)
fblundun added a commit that referenced this issue Jul 9, 2014
@fblundun
Removed enrichment-specific code from EmrEtlRunner (#811)
5b30db3 
Replaced enrichment-specific args from Emr-EtlRunner -> Hadoop Enrich, replaced with enrichments JSON (#808)
@alexanderdean
Copy link
Member Author

Fixed in 0.9.6, closing

peel pushed a commit to snowplow/emr-etl-runner that referenced this issue May 26, 2020
@fblundun @peel
Removed enrichment-specific code from EmrEtlRunner (snowplow/snowplow…
288de99 
…#811)

Replaced enrichment-specific args from Emr-EtlRunner -> Hadoop Enrich, replaced with enrichments JSON (snowplow/snowplow#808)
peel pushed a commit to snowplow/emr-etl-runner that referenced this issue May 28, 2020
@fblundun @peel
Removed enrichment-specific code from EmrEtlRunner (snowplow/snowplow…
dc20196 
…#811)

Replaced enrichment-specific args from Emr-EtlRunner -> Hadoop Enrich, replaced with enrichments JSON (snowplow/snowplow#808)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fblundun fblundun

Labels
3. Enrich
Projects
None yet
Milestone
Version 0.9.6
Development

No branches or pull requests
2 participants
@alexanderdean @fblundun