Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scala Hadoop Enrich: remove %3D handling for compatibility with old Scalding Args #850

Closed
alexanderdean opened this issue Jun 22, 2014 · 2 comments
Closed

Scala Hadoop Enrich: remove %3D handling for compatibility with old Scalding Args #850

alexanderdean opened this issue Jun 22, 2014 · 2 comments
Assignees
@fblundun
Labels
3. Enrich
Milestone
Version 0.9.6

Comments

@alexanderdean
Copy link
Member

Talk to Alex about this.
@alexanderdean alexanderdean added this to the JSON-powered enrichments milestone Jun 22, 2014
@alexanderdean
Copy link
Member Author

You should be good to go on this one. It involves simply removing any %3D decoding from this file:

https://github.com/snowplow/snowplow/blob/feature/json-enrichments/3-enrich/scala-hadoop-enrich/src/main/scala/com.snowplowanalytics.snowplow.enrich.hadoop/utils/ScalazArgs.scala#L95

i.e. remove the method and calls to it.

fblundun added a commit that referenced this issue Jun 25, 2014
@fblundun
Scala Hadoop Enrich: removed %3D support (#850)
89f42f5
fblundun added a commit that referenced this issue Jun 25, 2014
@fblundun
Scala Hadoop Enrich: removed %3D support (#850)
cda6b35
@fblundun fblundun changed the title Scala Hadoop Enrich: remove %3D support Scala Hadoop Enrich: remove %3D handling for compatibility with old Scalding Args Jun 25, 2014
fblundun added a commit that referenced this issue Jul 9, 2014
@fblundun
Scala Hadoop Enrich: removed %3D support (#850)
2c63a45
@alexanderdean
Copy link
Member Author

Fixed in 0.9.6, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fblundun fblundun

Labels
3. Enrich
Projects
None yet
Milestone
Version 0.9.6
Development

No branches or pull requests
2 participants
@alexanderdean @fblundun