Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala Common Enrich: make referer parsing configurable with list of internal domains #857

Closed
alexanderdean opened this issue Jun 25, 2014 · 1 comment
Assignees
Milestone

Comments

@alexanderdean
Copy link
Member

Should be configurable with an array string of the internal domains used to identify internal referers.

This is a four step process:

  1. Define JSON Schema for the new enrichment
  2. Update the existing referer parsing code to be a configurable enrichment in the new registry
  3. Java & Scala: add configurable list of domains which should count as "internal" snowplow-referer-parser/referer-parser#18
  4. Integrate updated version of referer-parser into Scala Common Enrich and activate the new functionality

Ask Alex for guidance when you get to step 3 above. 1 and 2 should be uncontroversial.

@alexanderdean
Copy link
Member Author

Fixed in 0.9.6, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants