Scala Kinesis Enrich: unified logger configuration #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazjote
changed the title
|
Makes sense! Thanks for the contrib. Can't see you guys in the CLA yet - https://github.com/snowplow/snowplow/wiki/CLA |
|
I have just signed CLA - thanks! |
|
Confirmed @kazjote - thanks so much! |
alexanderdean
modified the milestones:
Release 61 Pygmy Parrot,
Release 62 Tropical Parula
alexanderdean
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I can't configure logging level of Scala Kinesis Enricher. I can configure the level for Snowplow part of the app but not AWS libraries.
Solution
Including log4j-over-slf4j unifies the way of configuring logging for both Snowplow part and AWS library. For example, I can decrease the level of logging with:
-Dorg.slf4j.simpleLogger.defaultLogLevel=warn