Scala Stream Collector: allow use of the originating scheme during cookie bounce #3512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rbolkey has signed the Software Grant and Corporate Contributor License Agreement. Thanks so much |
BenFradet
reviewed
Nov 21, 2017
| RawHeader("P3P", "policyref=\"%s\", CP=\"%s\"".format(config.p3p.policyRef, config.p3p.CP)), | ||
| accessControlAllowOriginHeader(request), | ||
| `Access-Control-Allow-Credentials`(true) | ||
| ) |
There was a problem hiding this comment.
can we leave this as it was?
There was a problem hiding this comment.
woops ... didn't realize I had changed that
| queryParams: Map[String, String], | ||
| uri: Uri, | ||
| cookieBounceName: String, | ||
| queryParams: Map[String,String], |
There was a problem hiding this comment.
nit: missing space [String, String]
| enabled: Boolean, | ||
| name: String, | ||
| fallbackNetworkUserId: String, | ||
| forwardedProtocolHeader: Option[String] |
| ) | ||
| }.getOrElse(redirectUri) | ||
|
|
||
| Some(`Location`(redirectUriWithForwardedScheme)) | ||
| } else { | ||
| None | ||
| } |
There was a problem hiding this comment.
let's refactor this as:
if (bounce) {
val forwardedScheme = for {
headerName <- bounceConfig.forwardedProtocolHeader
headerValue <- request.headers.find(_.lowercaseName == headerName.toLowerCase)
scheme <-
if (Set("http", "https").contains(headerValue)) {
Some(headerValue)
else {
logger.warn(s"Header $headerName contains invalid protocol value $headerValue.")
None
}
} yield scheme
val redirectUri = request.uri
.withQuery(Uri.Query(queryParams + (bounceConfig.name -> "true")))
.withScheme(forwardedScheme.getOrElse(request.uri.scheme))
Some(`Location`(redirectUri))
} else {
None
}
|
Thanks @BenFradet. I've applied the recommended changes. Let me know if I missed anything. |
BenFradet
approved these changes
Nov 22, 2017
| # Optionally, specify the name of the header containing the originating protocol for use in the bounce redirect | ||
| # location. Use this if behind a load balancer that performs SSL termination. The value of this header must | ||
| # be http or https. Example, if behind an AWS Classic ELB. | ||
| forwardedProtocolHeader: "X-Forwarded-Proto" |
added 3 commits
November 22, 2017 16:06
Commit adds a new configuration parameter (`forwardedProtocolHeader`) in the cookie bounce feature. This parameter specifies the name of an http header that contains the originating protocol if deployed behind a load balancer. This is useful if SSL termination happens at the load balancer in order to maintain the security model of you web page.
rbolkey
force-pushed
the
onespot-forwarded-proto-in-cookie-bounce
branch
from
3f04abf
to
f6ae60d
Compare
|
@BenFradet fixed the example config, and rebased. |
BenFradet
changed the title
BenFradet
pushed a commit
that referenced
this pull request
Dec 15, 2017
…okie bounce (closes #3512) Commit adds a new configuration parameter (`forwardedProtocolHeader`) in the cookie bounce feature. This parameter specifies the name of an http header that contains the originating protocol if deployed behind a load balancer. This is useful if SSL termination happens at the load balancer in order to maintain the security model of you web page.
BenFradet
pushed a commit
that referenced
this pull request
Dec 15, 2017
…okie bounce (closes #3512) Commit adds a new configuration parameter (`forwardedProtocolHeader`) in the cookie bounce feature. This parameter specifies the name of an http header that contains the originating protocol if deployed behind a load balancer. This is useful if SSL termination happens at the load balancer in order to maintain the security model of you web page.
BenFradet
pushed a commit
that referenced
this pull request
Dec 15, 2017
…okie bounce (closes #3512) Commit adds a new configuration parameter (`forwardedProtocolHeader`) in the cookie bounce feature. This parameter specifies the name of an http header that contains the originating protocol if deployed behind a load balancer. This is useful if SSL termination happens at the load balancer in order to maintain the security model of you web page.
lukeindykiewicz
pushed a commit
to snowplow/stream-collector
that referenced
this pull request
Jun 4, 2020
…plow/snowplow#3512) Commit adds a new configuration parameter (`forwardedProtocolHeader`) in the cookie bounce feature. This parameter specifies the name of an http header that contains the originating protocol if deployed behind a load balancer. This is useful if SSL termination happens at the load balancer in order to maintain the security model of you web page.
lukeindykiewicz
pushed a commit
to snowplow/stream-collector
that referenced
this pull request
Jun 5, 2020
…plow/snowplow#3512) Commit adds a new configuration parameter (`forwardedProtocolHeader`) in the cookie bounce feature. This parameter specifies the name of an http header that contains the originating protocol if deployed behind a load balancer. This is useful if SSL termination happens at the load balancer in order to maintain the security model of you web page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit adds a new configuration parameter (
forwardedProtocolHeader) in thecookie bounce feature. This parameter specifies the name of an http header
that contains the originating protocol if deployed behind a load balancer.
This is useful if SSL termination happens at the load balancer in order to
maintain the security model of you web page.
Fixes #3505