Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala Stream Collector: bump kafka client to 2.1.1 #3981

Conversation

mirkoprescha
Copy link
Contributor

This PR is a follow-up on force pushed #3973

This allows Scala Stream Collector to use new Kafka ProducerConfigs introduced in 2.1.0, e.g. delivery.timeout.ms
Together with new feature to set arbitrary kafka producer settings we can better customize our kafka sink.

@snowplowcla
Copy link

Confirmed! @mirkoprescha has signed the Individual Contributor License Agreement. Thanks so much

@BenFradet BenFradet changed the base branch from master to release/r113-filitosa February 18, 2019 08:43
@BenFradet BenFradet changed the title Scala Stream Collector: bump kafka producer client to 2.1.0. This all… Scala Stream Collector: bump kafka client to 2.1.0 Feb 18, 2019
Copy link
Contributor

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again 👍

@BenFradet BenFradet merged commit b74d5ad into snowplow:release/r113-filitosa Feb 18, 2019
@BenFradet BenFradet changed the title Scala Stream Collector: bump kafka client to 2.1.0 Scala Stream Collector: bump kafka client to 2.1.1 Feb 20, 2019
lukeindykiewicz pushed a commit to snowplow/stream-collector that referenced this pull request Jun 4, 2020
lukeindykiewicz pushed a commit to snowplow/stream-collector that referenced this pull request Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants