-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scala Stream Collector: bump kafka client to 2.1.1 #3981
Merged
BenFradet
merged 1 commit into
snowplow:release/r113-filitosa
from
mirkoprescha:feature/bump-kafka-version-to-2.1.0
Feb 18, 2019
Merged
Scala Stream Collector: bump kafka client to 2.1.1 #3981
BenFradet
merged 1 commit into
snowplow:release/r113-filitosa
from
mirkoprescha:feature/bump-kafka-version-to-2.1.0
Feb 18, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ows usage of delivery.timeout.ms
Confirmed! @mirkoprescha has signed the Individual Contributor License Agreement. Thanks so much |
BenFradet
changed the title
Scala Stream Collector: bump kafka producer client to 2.1.0. This all…
Scala Stream Collector: bump kafka client to 2.1.0
Feb 18, 2019
BenFradet
force-pushed
the
release/r113-filitosa
branch
from
February 18, 2019 08:45
6447fb2
to
4ffbc25
Compare
BenFradet
approved these changes
Feb 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again 👍
BenFradet
pushed a commit
that referenced
this pull request
Feb 18, 2019
BenFradet
changed the title
Scala Stream Collector: bump kafka client to 2.1.0
Scala Stream Collector: bump kafka client to 2.1.1
Feb 20, 2019
BenFradet
pushed a commit
that referenced
this pull request
Feb 20, 2019
BenFradet
pushed a commit
that referenced
this pull request
Feb 20, 2019
BenFradet
pushed a commit
that referenced
this pull request
Feb 25, 2019
BenFradet
pushed a commit
that referenced
this pull request
Feb 27, 2019
BenFradet
pushed a commit
that referenced
this pull request
Feb 27, 2019
lukeindykiewicz
pushed a commit
to snowplow/stream-collector
that referenced
this pull request
Jun 4, 2020
lukeindykiewicz
pushed a commit
to snowplow/stream-collector
that referenced
this pull request
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up on force pushed #3973
This allows Scala Stream Collector to use new Kafka ProducerConfigs introduced in 2.1.0, e.g. delivery.timeout.ms
Together with new feature to set arbitrary kafka producer settings we can better customize our kafka sink.