Test bugfix #171
Closed
Test bugfix #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's neat. |
|
Issue raised with the API: googleapis/google-cloud-go#3304 |
|
Closing in favour of #172 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the splitting of scripts by
;characters. Instead, we attempt to run the entire script, which can contain multiple statements.This has the unhappy side effect of causing the BQ api to sometimes fail with success - where any but the last statement hits an error.
I believe this to be a bug in the API, since the query does actually fail, and once the error is retrieved it is of a different format to elsewhere (suggesting that it's potentially been handled for others where it's not handled in this case - will raise an issue with them once I've had a chance to produce a clean repro).
This is handled in our code by explicitly checking for an error after the query is complete, before moving on to the next query.