Add -continueOnError flag #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the playbook to be executed until the end even with a failed step
|
Confirmed! @andremidea has signed the Individual Contributor License Agreement |
|
Can we do anything to have this PR merged? :-) |
BenFradet
reviewed
Jul 12, 2017
| 0.6.0 |
There was a problem hiding this comment.
we will take care of that ourselves 👍
| @@ -25,7 +25,7 @@ import ( | |||
| const ( | |||
| CLI_NAME = "sql-runner" | |||
| CLI_DESCRIPTION = `Run playbooks of SQL scripts in series and parallel on Redshift and Postgres` | |||
| CLI_VERSION = "0.5.2" | |||
| CLI_VERSION = "0.6.0" | |||
| @@ -65,6 +66,7 @@ func (o *Options) GetFlagSet() *flag.FlagSet { | |||
| fs.Var(&(o.variables), "var", "Variables to be passed to the playbook, in the key=value format") | |||
| fs.StringVar(&(o.fromStep), "fromStep", "", "Starts from a given step defined in your playbook") | |||
| fs.BoolVar(&(o.dryRun), "dryRun", false, "Runs through a playbook without executing any of the SQL") | |||
| fs.BoolVar(&(o.continueOnError), "continueOnError", false, "Continues execution even a step fails, the exit code will still be different than 0") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use case for this flag is the following:
We have a daily job that loads automatically ~500 tables, everything is generated programmatically (we generate DDL based on the Spark's Dataset Schema) and sometimes one of the loads fails, given that, all subsequent steps are skipped, this is not great for us because we have some next steps that must be run.
So the idea here is to add the possibility of continuing the execution of the subsequent steps but still return an error code at the end (and also tell which queries failed)
ps: I signed the CLA