Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default value of pubsub backoffPolicy totalBackoff #187

Closed
istreeter opened this issue Nov 11, 2021 · 1 comment
Closed

Increase default value of pubsub backoffPolicy totalBackoff #187

istreeter opened this issue Nov 11, 2021 · 1 comment
Milestone

Comments

@istreeter
Copy link
Contributor

The current default value is 10 seconds. This means if the collector cannot publish to pubsub within 10 seconds then an event is dropped and an error is logged.

It is a principle of the collector that should never drop any event, but instead should continue to accept events in the hope that downstream errors are transient. A better value for backoffPolicy.totalBackoff is 9223372036854, which is the largest allowed value in milliseconds. This will prevent data loss in the case when the collector is publishing events to pubsub more quickly than pubsub allows.

In the meantime, users can override the default value to 9223372036854 in their config file.

@istreeter
Copy link
Contributor Author

Linking to relevant conversation on Discourse. We should also make the RPC timeouts configurable, and use a larger default for maxRpcTimeout.

@istreeter istreeter added this to the 2.5.0 milestone Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant