Adding buffer size to sourceHandleRange #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -181,7 +182,20 @@ sourceHandleRange :: MonadIO m | |||
| -> Maybe Integer -- ^ Offset | |||
| -> Maybe Integer -- ^ Maximum count | |||
| -> Producer m S.ByteString | |||
| sourceHandleRange handle offset count = do | |||
| sourceHandleRange handle offset count = | |||
| sourceHandleRangeWithBuffer handle offset count 4096 | |||
There was a problem hiding this comment.
Ouch, having the buffer size so low in the first place was a big mistake. I'll fix that also.
snoyberg
added a commit
that referenced
this pull request
May 12, 2015
Adding buffer size to sourceHandleRange
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're reading from disk and uploading parts of files using http-conduit and we've observed that the buffer size has significant impact on performance. On certain machines going from a 4k buffer to a 1mb buffer results in a 4x speed up.
Not 100% on the signature that you would prefer, this lets us achieve what we need. If you would like it in a slightly different form just let me know.