Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookies: equal vs. equiv #435

Merged
merged 14 commits into from
May 26, 2020
Merged

Cookies: equal vs. equiv #435

merged 14 commits into from
May 26, 2020

Conversation

fisx
Copy link
Contributor

@fisx fisx commented May 24, 2020

this may one day fix #433

@fisx fisx mentioned this pull request May 24, 2020
Closed
@fisx fisx changed the title [WIP] Failing test case. Cookies: equal vs. equiv May 25, 2020
snoyberg
snoyberg requested changes May 25, 2020
View reviewed changes
http-client/Network/HTTP/Client/Types.hs Outdated Show resolved Hide resolved
http-client/Network/HTTP/Client/Types.hs Show resolved Hide resolved
http-client/Network/HTTP/Client/Types.hs Outdated Show resolved Hide resolved
@fisx
Copy link
Contributor Author

fisx commented May 26, 2020

If I'm reading the right part of the log this time, the errors on windows are really unrelated:

cryptonite           > [104 of 131] Compiling Crypto.PubKey.ECC.P256
cryptonite           > [105 of 131] Compiling Crypto.PubKey.Curve448
cryptonite           > 
cryptonite           > Access violation in generated code when writing 0x0
cryptonite           > 
cryptonite           >  Attempting to reconstruct a stack trace...
cryptonite           > 
cryptonite           >    Frame	Code address
cryptonite           >  * 0x461da80	0x37f7b66 C:\Users\VssAdministrator\AppData\Local\Programs\stack\x86_64-windows\ghc-8.8.3\bin\ghc.exe+0x33f7b66
cryptonite           >  * 0x461da88	0x3277bb9 C:\Users\VssAdministrator\AppData\Local\Programs\stack\x86_64-windows\ghc-8.8.3\bin\ghc.exe+0x2e77bb9
cryptonite           >  * 0x461da90	0x5
cryptonite           >  * 0x461da98	0x5
cryptonite           >  * 0x461daa0	0x3d7dc22 C:\Users\VssAdministrator\AppData\Local\Programs\stack\x86_64-windows\ghc-8.8.3\bin\ghc.exe+0x397dc22
cryptonite           >  * 0x461daa8	0xa948e10
cryptonite           > 
[...]

--  While building package cryptonite-0.26 using:
      D:\a\1\s\.stack-root\setup-exe-cache\x86_64-windows\Cabal-simple_Z6RU0evB_3.0.1.0_ghc-8.8.3.exe --builddir=.stack-work\dist\29cc6475 build --ghc-options " -fdiagnostics-color=always"
    Process exited with code: ExitFailure 11

Everything else is green.

snoyberg
snoyberg approved these changes May 26, 2020
View reviewed changes
Copy link
Owner

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snoyberg snoyberg merged commit e57ee1e into snoyberg:master May 26, 2020
@sternenseemann sternenseemann mentioned this pull request Jun 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snoyberg snoyberg snoyberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cookie equality should not be replacabiltiy
2 participants
@fisx @snoyberg