Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set modification time before file mode on Windows #25

Merged
merged 1 commit into from
Nov 19, 2018

Conversation

gaborh-da
Copy link
Contributor

If one sets the file mode first, then a read only file's modification
time cannot be set.

If one sets the file mode first, then a read only file's modification
time cannot be set.
@lehins
Copy link
Collaborator

lehins commented Nov 19, 2018

@gaborh-da you are totally right, we need to update that behavior on unix as well. I mistakenly thought updating attributes will update the mtime, but it only updates ctime. I'll merge the PR a bit later, change the behavior on Unix and do a release later on today.

@gaborh-da
Copy link
Contributor Author

@lehins I am not sure it needs update on Unix. I tried the following scenario:

  1. touched a file
  2. chmod 400 on that file which should be read only
  3. then, chmod 555 and it still worked

@lehins lehins merged commit 3c9fd33 into snoyberg:master Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants