html-conduit: Entity decoding in attributes in 1.3.1 cuts off after & #038;

[valpackett]

Test started failing after stackage upgraded to 1.3.1: https://github.com/myfreeweb/microformats2-parser/issues/5

Basically in

<a href="https://example.com?a=b&#038;c=d">link</a>

href gets decoded as https://example.com?a=b which is certainly not what I would expect.

[snoyberg]

I was unable to repro with a451a48. Can you provide a reproducing test case against html-conduit?

[snoyberg]

Just a guess: is it possible that you had a workaround in place previously to deal with the lack of entity decoding in tagstream-conduit, and introducing this bugfix caused you to double-unescape the entities?

[valpackett]

Oh. Sorry, yeah, that's it.

[snoyberg]

No worries, it was the only workaround for this buggy behavior before.