Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New render setting to control when to use CDATA #68

Merged
merged 1 commit into from Dec 20, 2015

Conversation

Projects
None yet
2 participants
@vigoo
Copy link
Contributor

vigoo commented Dec 16, 2015

Adds a new function to RenderSettings which can decide whether to render the given content node as a CDATA or as text.

@@ -72,6 +73,9 @@ data RenderSettings = RenderSettings
, rsAttrOrder :: Name -> Map.Map Name Text -> [(Name, Text)]
-- ^ Specify how to turn the unordered attributes used by the "Text.XML"
-- module into an ordered list.
, rsUseCDATA :: Content -> Bool
-- ^ Determines if for a given text content the renderer should use a
-- CDATA node.

This comment has been minimized.

Copy link
@snoyberg

snoyberg Dec 20, 2015

Owner

Should include a comment that the default in False and a @since indicating the version this was added.

This comment has been minimized.

Copy link
@snoyberg

snoyberg Dec 20, 2015

Owner

I'll just update this when merging actually.

@snoyberg snoyberg merged commit 9075547 into snoyberg:master Dec 20, 2015

snoyberg added a commit that referenced this pull request Dec 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.