New render setting to control when to use CDATA #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -72,6 +73,9 @@ data RenderSettings = RenderSettings | |||
| , rsAttrOrder :: Name -> Map.Map Name Text -> [(Name, Text)] | |||
| -- ^ Specify how to turn the unordered attributes used by the "Text.XML" | |||
| -- module into an ordered list. | |||
| , rsUseCDATA :: Content -> Bool | |||
| -- ^ Determines if for a given text content the renderer should use a | |||
| -- CDATA node. | |||
There was a problem hiding this comment.
Should include a comment that the default in False and a @since indicating the version this was added.
There was a problem hiding this comment.
I'll just update this when merging actually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new function to
RenderSettingswhich can decide whether to render the given content node as a CDATA or as text.