Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escaping CDATA closing tag in CDATA #69

Merged
merged 3 commits into from Dec 21, 2015

Conversation

Projects
None yet
2 participants
@vigoo
Copy link
Contributor

vigoo commented Dec 16, 2015

Handles CDATA closing tag (]]>) while rendering CDATA in the same way as the Text.XML.Light package does.

@vigoo

This comment has been minimized.

Copy link
Contributor Author

vigoo commented Dec 16, 2015

Note: depends on #68 because of it's unit test case.

@snoyberg

This comment has been minimized.

Copy link
Owner

snoyberg commented Dec 20, 2015

This looks like a terribly inefficient implementation. Wouldn't a simple call to Data.Text.replace be simpler and more efficient?

@vigoo

This comment has been minimized.

Copy link
Contributor Author

vigoo commented Dec 21, 2015

Yes you are right, I guess I was tired :)

snoyberg added a commit that referenced this pull request Dec 21, 2015

Merge pull request #69 from vigoo/cdata-escape
Escaping CDATA closing tag in CDATA

@snoyberg snoyberg merged commit c95bcd0 into snoyberg:master Dec 21, 2015

@snoyberg

This comment has been minimized.

Copy link
Owner

snoyberg commented Dec 21, 2015

Cool, merged

snoyberg added a commit that referenced this pull request Dec 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.