Proper handling of String +123 serialization (fixes #64)

snoyberg · Jul 20, 2015 · 438f0bc · 438f0bc
1 parent 963ba05
commit 438f0bc
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 1 deletion.
diff --git a/ChangeLog.md b/ChangeLog.md
@@ -1,3 +1,7 @@
+## 0.8.12
+
+* Proper handling of `String "+123"` [#64](https://github.com/snoyberg/yaml/issues/64)
+
 ## 0.8.11
 
 * Function to print prettier parse exceptions [#59](https://github.com/snoyberg/yaml/pull/59)

diff --git a/Data/Yaml.hs b/Data/Yaml.hs
@@ -158,6 +158,7 @@ isNumeric =
                 || c == 'E'
                 || c == '.'
                 || c == '-'
+                || c == '+'
 
 decode :: FromJSON a
        => ByteString

diff --git a/test/Data/YamlSpec.hs b/test/Data/YamlSpec.hs
@@ -140,6 +140,9 @@ spec = do
 
     it "aliases in keys #49" caseIssue49
 
+    it "serialization of +123 #64" $ do
+        D.decode (D.encode ("+123" :: String)) `shouldBe` Just ("+123" :: String)
+
 
 specialStrings :: [T.Text]
 specialStrings =

diff --git a/yaml.cabal b/yaml.cabal
@@ -1,5 +1,5 @@
 name:            yaml
-version:         0.8.11
+version:         0.8.12
 license:         BSD3
 license-file:    LICENSE
 author:          Michael Snoyman <michael@snoyman.com>, Anton Ageev <antage@gmail.com>,Kirill Simonov