Add !include syntax support for config file reading.
#87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… supports 'include' syntax.
|
Can you add a minor version bump in the .cabal file and make an update to the ChangeLog explaining the new behavior? |
|
@snoyberg, most certainly. Done. |
| @@ -1,5 +1,5 @@ | |||
| name: yaml | |||
| version: 0.8.17.2 | |||
| version: 0.8.17.3 | |||
There was a problem hiding this comment.
This is a patch bump. Since this is a potentially surprising change in behavior, I'd rather a minor version bump (which can be tracked via Cabal CPP macros). In this case: 0.8.18.
There was a problem hiding this comment.
Good point, haven't even thought of that.
There was a problem hiding this comment.
It takes getting bitten by it many times to start thinking about it :)
…ntrolled by CPP if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched yaml decode function for config file readers to the one from
Data.Yaml.Includethat supports!includesyntax.This change should be backwards compatible and should allow for multi package projects to mutually reuse config files.