Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle non-ASCII filenames correctly on Windows #91

Merged
merged 5 commits into from
Aug 31, 2016
Merged

Handle non-ASCII filenames correctly on Windows #91

merged 5 commits into from
Aug 31, 2016

Commits on Aug 14, 2016

  1. Open files through GHC intl-safe API (snoyberg#90) 

    Fix snoyberg#90. Idea: reuse low-level API from GHC internals, since it has
already tested low-level code to deal with non-ASCII filenames on
different platforms.
    @Blaisorblade
    Blaisorblade committed Aug 14, 2016
    Configuration menu
    Copy the full SHA
    e2109cd View commit details
    Browse the repository at this point in the history

  2. Drop redundant fclose_helper call 

    A null file pointer doesn't need closing; `fclose_helper` will indeed do
nothing on a null pointer.
    @Blaisorblade
    Blaisorblade committed Aug 14, 2016
    Configuration menu
    Copy the full SHA
    e878add View commit details
    Browse the repository at this point in the history

  3. Add testcase 

    I've ensured both parts of the test fail without the changes.

To ensure the whole test fails without the fixes, accented characters
must be in the path argument, not just in the current working directory.
    @Blaisorblade
    Blaisorblade committed Aug 14, 2016
    Configuration menu
    Copy the full SHA
    8b43126 View commit details
    Browse the repository at this point in the history

  4. Silence unrelated compiler warning

    @Blaisorblade
    Blaisorblade committed Aug 14, 2016
    Configuration menu
    Copy the full SHA
    057737e View commit details
    Browse the repository at this point in the history

  5. Bump version and add changelog

    @Blaisorblade
    Blaisorblade committed Aug 14, 2016
    Configuration menu
    Copy the full SHA
    5c2b6b2 View commit details
    Browse the repository at this point in the history