Fixed MinidumpTest.TestMinidumpFromStream opening minidump on Windows.

Minidump file needs to be opened as binary.
snxd · Dec 29, 2023 · ab97981 · ab97981
1 parent ffb0492
commit ab97981
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/processor/minidump_unittest.cc b/src/processor/minidump_unittest.cc
@@ -111,7 +111,7 @@ TEST_F(MinidumpTest, TestMinidumpFromFile) {
 
 TEST_F(MinidumpTest, TestMinidumpFromStream) {
   // read minidump contents into memory, construct a stringstream around them
-  ifstream file_stream(minidump_file_.c_str(), std::ios::in);
+  ifstream file_stream(minidump_file_.c_str(), std::ios::in | std::ios::binary);
   ASSERT_TRUE(file_stream.good());
   vector<char> bytes;
   file_stream.seekg(0, std::ios_base::end);