fix: better error messages for unsuccessful API responses #23
Conversation
mcombuechen
force-pushed
the
fix/LINK-212-unsuccessful-response
branch
2 times, most recently
from
6c91b54
to
76e5a7b
Compare
| return extension_errors.New( | ||
| err, | ||
| fmt.Sprintf( | ||
| "Your account is not authorized to perform this action. "+ |
There was a problem hiding this comment.
we dont take into account the error messages from the hidden endpoint do we?
There was a problem hiding this comment.
As of now, no we don’t. But I’m open to suggestions here. In a previous iteration the status code was part of the message (Your account is not authorized to perform this action. (Status: 4xx)) but that made it look cryptic to me.
There was a problem hiding this comment.
In that we should consider removing from the error catalog any errors only used by the hidden endpoint. For example
Although, if it did use the error catalog I could see it being useful for the user to get a link to retrieve their API token; my understanding thats not possible yet for the cli.
There was a problem hiding this comment.
Yes, the way it works right now is that we return a Golang error, which basically only has a string value which will be displayed to the user. This is not ideal for many reasons, but most of all that you cannot make a distinction between a cryptic message that would help with debugging, and a user-friendly one that would read nicely and be helpful to our end users. Right now we are prioritizing the user-friendliness and disregarding the internal debugging stuff. This is a temporary solution until the error catalog makes it into the CLI, which should hopefully happen soon. We can then revise all of this and introduce error codes etc. as well.
mcombuechen
force-pushed
the
fix/LINK-212-unsuccessful-response
branch
from
76e5a7b
to
5b695c9
Compare
This adds user-friendly error messages for unsuccessful API responses, such as