Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add proxy support when fetching patches #122

Merged

Conversation

timja
Copy link
Contributor

@timja timja commented Jan 8, 2018

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Adds proxy support when fetching patches, see #112

Let me know if you think this should be refactored into the lib/request/request file,

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

#112

What are the relevant tickets?

Screenshots

Additional questions

@adrukh
Copy link
Contributor

adrukh commented Jan 8, 2018

Thanks @timja-kainos, we'll release this fix later this week!

@adrukh adrukh changed the base branch from master to fix/patch-proxy-support January 9, 2018 07:06
@adrukh
Copy link
Contributor

adrukh commented Jan 9, 2018

Merging to a side branch to go through our internal song-and-dance release process 💃

@adrukh adrukh merged this pull request into snyk:fix/patch-proxy-support Jan 9, 2018
@adrukh
Copy link
Contributor

adrukh commented Jan 9, 2018

This is now pushed at 3e409ca and released with https://github.com/snyk/snyk/releases/tag/v1.66.0

Thanks for the contribution!

@timja timja deleted the fix/fetch-patch-proxy-support branch January 9, 2018 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants