-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add proxy support when fetching patches #122
Merged
adrukh
merged 1 commit into
snyk:fix/patch-proxy-support
from
timja:fix/fetch-patch-proxy-support
Jan 9, 2018
Merged
fix: add proxy support when fetching patches #122
adrukh
merged 1 commit into
snyk:fix/patch-proxy-support
from
timja:fix/fetch-patch-proxy-support
Jan 9, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Thanks @timja-kainos, we'll release this fix later this week! |
Merging to a side branch to go through our internal song-and-dance release process 💃 |
This is now pushed at 3e409ca and released with https://github.com/snyk/snyk/releases/tag/v1.66.0 Thanks for the contribution! |
This was referenced Sep 12, 2021
This was referenced May 13, 2022
This was referenced Sep 30, 2022
This was referenced Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds proxy support when fetching patches, see #112
Let me know if you think this should be refactored into the lib/request/request file,
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
#112
What are the relevant tickets?
Screenshots
Additional questions