Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct classpath extraction for reachable vulns on windows #1470

Merged
merged 1 commit into from
Oct 15, 2020

Conversation

darmalovan
Copy link

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Sets that right command for maven to get the classpath for the
correct repo.

For more info go to:
snyk/java-call-graph-builder#36

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What are the relevant tickets?

Screenshots

Additional questions

Sets that right command for maven to get the classpath for the
correct repo.

For more info go to:
snyk/java-call-graph-builder#36
@darmalovan darmalovan requested review from a team as code owners October 14, 2020 16:06
@darmalovan darmalovan self-assigned this Oct 14, 2020
@ghost ghost requested review from anthogez and orsagie October 14, 2020 16:06
@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2020

Expected release notes (by @darmalovan)

fixes:
correct classpath extraction for reachable vulns on windows (a932db8)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@github-actions
Copy link
Contributor

Warnings
⚠️

Looks like you added a new Tap test. Consider making it a Jest test instead. See files like test/*.spec.ts for examples. Files found:

Generated by 🚫 dangerJS against a932db8

@darmalovan darmalovan merged commit 27f7235 into master Oct 15, 2020
@darmalovan darmalovan deleted the feat/update-mvn-plugin branch October 15, 2020 06:44
@snyksec
Copy link

snyksec commented Oct 15, 2020

🎉 This PR is included in version 1.413.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants