This repository was archived by the owner on Jan 9, 2024. It is now read-only.
fix: support getting maven classpath for windows #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
windows doesn't support using `echo` out of the box, there is a need to pass it with through `cmd`.
muscar
approved these changes
Oct 14, 2020
|
🎉 This PR is included in version 1.16.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
darmalovan
pushed a commit
to snyk/snyk-mvn-plugin
that referenced
this pull request
Oct 14, 2020
3 tasks
darmalovan
pushed a commit
to snyk/cli
that referenced
this pull request
Oct 14, 2020
Sets that right command for maven to get the classpath for the correct repo. For more info go to: snyk/java-call-graph-builder#36
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Support getting maven classpath for windows
Windows don't support using
echoout of the box, there is a need to pass it with throughcmd.More information