docs: update container command help #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JackuB
approved these changes
Jan 6, 2022
Avishagp
approved these changes
Jan 6, 2022
maxjeffos
previously requested changes
Jan 10, 2022
JackuB
force-pushed
the
docs/revise-container-command-help
branch
from
656f7f5
to
135b0ea
Compare
snaftaly
reviewed
Jan 11, 2022
|
I have made a note of this and will go over a proposed change with the CLI
development team.
…On Tue, Jan 11, 2022 at 7:56 AM Sharon Naftaly ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In help/cli-commands/container.md
<#2515 (comment)>:
>
-#### `HTTPS_PROXY` and `HTTP_PROXY`
+Allowed platforms are: `linux/amd64`, `linux/arm64`, `linux/riscv64`, `linux/ppc64le`, `linux/s390x`, `linux/386`, `linux/arm/v7`, or `linux/arm/v6`.
What do you think about using "Supported platforms" instead of "Allowed
platforms"?
—
Reply to this email directly, view it on GitHub
<#2515 (review)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWWRPDERI56EIBHLHNXPHZTUVQSJVANCNFSM5LGNRTXQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Avishagp
force-pushed
the
docs/revise-container-command-help
branch
from
135b0ea
to
48354fd
Compare
Avishagp
force-pushed
the
docs/revise-container-command-help
branch
from
48354fd
to
784e14f
Compare
Avishagp
force-pushed
the
docs/revise-container-command-help
branch
from
784e14f
to
022aefe
Compare
This was referenced Aug 30, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file has all revisions through January 3, 2022, for review by the Hammer team. Question: For commands with the sub-command test, should the test command be explained the same as as the snyk test command: test a project for open source vulnerabilities and license issues? At this time, the code and iac commands say: test for any known issue. The container command says: test for any known vulnerabilities.