Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): run lint and build in parallel #2528

Merged
2 commits merged into from Jan 11, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
36 changes: 22 additions & 14 deletions .circleci/config.yml
Expand Up @@ -73,17 +73,6 @@ commands:
key: npm-cache-v2-{{ arch }}-node<< parameters.node_version >>-npm<< parameters.npm_version >>-{{ checksum "package-lock.json" }}
paths:
- << parameters.npm_cache_directory >>
build_project:
steps:
- run:
name: Building project
command: npm run build:prod
- persist_to_workspace:
root: .
paths:
- dist/
- packages/*/dist
- pysrc
install_sdks_windows:
steps:
- restore_cache:
Expand Down Expand Up @@ -170,7 +159,7 @@ commands:
sudo apt update
sudo apt install osslsigncode
jobs:
build:
lint:
<<: *defaults
docker:
- image: cimg/node:<< parameters.node_version >>
Expand All @@ -181,7 +170,23 @@ jobs:
- run:
name: Linting project
command: npm run lint
- build_project
build:
<<: *defaults
docker:
- image: circleci/node:<< parameters.node_version >>
steps:
- checkout
- install_project_dependencies:
node_version: << parameters.node_version >>
- run:
name: Building project
command: npm run build:prod
- persist_to_workspace:
root: .
paths:
- dist/
- packages/*/dist
- pysrc
regression-test:
<<: *defaults
docker:
Expand Down Expand Up @@ -443,9 +448,10 @@ workflows:
version: 2
test_and_release:
jobs:
- lint:
name: Lint
- build:
name: Build
context: nodejs-install

- regression-test:
name: Regression Tests
Expand Down Expand Up @@ -535,6 +541,7 @@ workflows:
- dev-release:
name: Development Release
requires:
- Lint
- Build
filters:
branches:
Expand All @@ -549,4 +556,5 @@ workflows:
only:
- master
requires:
- Lint
- Build
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -33,7 +33,7 @@
"check-dev-environment": "ts-node ./scripts/check-dev-environment.ts",
"format": "prettier --write '**/*.{js,ts,json,yaml,yml,md}'",
"format:changes": "./scripts/format/prettier-changes.sh",
"lint": "run-p --aggregate-output lint:*",
"lint": "npm-run-all --serial --continue-on-error lint:*",
This conversation was marked as resolved.
Show resolved Hide resolved
"lint:js": "eslint --color --cache '**/*.{js,ts}'",
"lint:formatting": "prettier --check '**/*.{js,ts,json,yaml,yml,md}'",
"build": "npm run build:dev",
Expand Down