chore(ci): run lint and build in parallel #2528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
chore/split-lint
branch
from
7bdf103
to
be334d5
Compare
added 2 commits
January 6, 2022 19:02
By moving the linter to its own job, we don't need to block test runs on minor linter errors. This lets contributors first get their work done without needing to polish and fix linter errors constantly throughout. Running the linter in parallel also saves 30s to 3 minutes (linter time varies). I've kept the linter requirement for dev-release as it should mirror prod-release as much as possible. And of course the linter (and every other job) should pass before we run a prod-release.
So that we can see all linter errors at once and fix them together. Changing npm-run-all to serial adds 10 seconds, but prevents linters from competing for resources. It also provides better progress output without needing to aggregate.
ghost
force-pushed
the
chore/split-lint
branch
from
be334d5
to
897ad08
Compare
ghost
mentioned this pull request
JackuB
reviewed
Jan 11, 2022
JackuB
approved these changes
Jan 11, 2022
|
If linter fails (quickly) - it will stop only the dev release, right? |
Yes, I kept the dependency there as it mirrors prod release. We shouldn't have linter errors at prod release, so dev release does the same check to make sure that flow works. |
This was referenced Aug 30, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By moving the linter to its own job, we don't need to block test runs on minor linter errors. This lets contributors first get their work done without needing to polish and fix linter errors constantly throughout.
Running the linter in parallel also saves 30s to 3 minutes (linter time varies).
I've kept the linter requirement for dev-release as it should mirror prod-release as much as possible. And of course the linter (and every other job) should pass before we run a prod-release.
Example: https://app.circleci.com/pipelines/github/snyk/snyk/8914/workflows/ed13ac3a-92ec-4aa6-91e7-c2e593354770