-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: quarantine tap tests #2530
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ghost
changed the title
chore: quarantine tap tests
chore: quarantine root and system tap tests
Jan 10, 2022
ghost
force-pushed
the
chore/quarantine-tap-tests
branch
2 times, most recently
from
January 10, 2022 22:25
96a6690
to
1afc2df
Compare
Warning spam makes it hard to see errors in CI output. They are still useful when editing indivudal files to avoid introducing more issues and resolving existing ones gradually.
ghost
force-pushed
the
chore/quarantine-tap-tests
branch
2 times, most recently
from
January 11, 2022 17:18
d4279ea
to
7ecd758
Compare
ghost
force-pushed
the
chore/quarantine-tap-tests
branch
from
January 11, 2022 18:40
7091235
to
7b7b89e
Compare
ghost
marked this pull request as ready for review
January 11, 2022 18:44
ghost
changed the title
chore: quarantine root and system tap tests
chore: quarantine tap tests
Jan 11, 2022
Avishagp
approved these changes
Jan 13, 2022
ghost
deleted the
chore/quarantine-tap-tests
branch
January 13, 2022 12:09
ghost
mentioned this pull request
Jan 19, 2022
This was referenced Aug 30, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having both Jest and Tap tests in the same test jobs in CI is confusing. We are migrating off of Tap tests and do not want contributors to modify them. If we need to modify them, they should be migrated to Jest tests first. So to make that clear, this PR is quarantining them. Which means they'll run in a separate job and be in their own directory
I've also moved all Tap tests to their own directory and flattened their hierarchy. This simplifies maintenance and allows use to easily parallelise them in CircleCi so that they finish quickly.
The PR looks quite large because files were moved. They all more or less have the same changes (fixing relative paths). The main changes are in the package.json scripts and CircleCI config.
In a future PR, Jest tests will be brought forward (they'll no longer be in their own "jest" directory). This change isn't included in this PR as Jest tests (and fixtures/workspaces) are actively worked on so they will cause merge conflicts. This PR is big enough moving all of the Tap tests.
Progresses #2509