Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: quarantine tap tests #2530

Merged
3 commits merged into from
Jan 13, 2022
Merged

chore: quarantine tap tests #2530

3 commits merged into from
Jan 13, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jan 7, 2022

Having both Jest and Tap tests in the same test jobs in CI is confusing. We are migrating off of Tap tests and do not want contributors to modify them. If we need to modify them, they should be migrated to Jest tests first. So to make that clear, this PR is quarantining them. Which means they'll run in a separate job and be in their own directory

I've also moved all Tap tests to their own directory and flattened their hierarchy. This simplifies maintenance and allows use to easily parallelise them in CircleCi so that they finish quickly.

The PR looks quite large because files were moved. They all more or less have the same changes (fixing relative paths). The main changes are in the package.json scripts and CircleCI config.

In a future PR, Jest tests will be brought forward (they'll no longer be in their own "jest" directory). This change isn't included in this PR as Jest tests (and fixtures/workspaces) are actively worked on so they will cause merge conflicts. This PR is big enough moving all of the Tap tests.

Progresses #2509

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2022

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • test/fixtures/docker/plugin-multiple-deps.ts
  • test/jest/unit/lib/formatters/remediation-based-format-issues.spec.ts
  • test/tap/cli-monitor.acceptance.test.ts
  • test/tap/cli-protect-no-vulns-to-patch.test.ts
  • test/tap/cli-protect.test.ts
  • test/tap/cli-test/cli-test.docker.spec.ts
  • test/tap/cli-test/cli-test.maven.spec.ts
  • test/tap/cli-test/cli-test.npm.spec.ts
  • test/tap/cli-test/cli-test.ruby.spec.ts
  • test/tap/cli-test/cli-test.sbt.spec.ts
  • test/tap/cli.test.ts
  • test/tap/dev-count-analysis.test.ts
  • test/tap/docker-token.test.ts
  • test/tap/get-remote-url.test.ts
  • test/tap/monitor-target.test.ts
  • test/tap/policy.test.ts
  • test/tap/prompt-instrument.test.ts
  • test/tap/prompts.test.ts
  • test/tap/protect-config.test.ts
  • test/tap/protect-patch-order.test.ts
  • test/tap/protect-semver-patch.test.ts
  • test/tap/reachable-vulns.test.ts
  • test/tap/run-test.test.ts
  • test/tap/severity-threshold.test.ts
  • test/tap/wizard-patch-multiple-locations.test.ts
  • test/tap/wizard-shrinkwrap.test.ts
Messages
📖

This PR will not trigger a new version. It doesn't include any commit message with feat or fix.

Generated by 🚫 dangerJS against 7b7b89e

@ghost ghost changed the title chore: quarantine tap tests chore: quarantine root and system tap tests Jan 10, 2022
@ghost ghost force-pushed the chore/quarantine-tap-tests branch 2 times, most recently from 96a6690 to 1afc2df Compare January 10, 2022 22:25
Jahed Ahmed added 2 commits January 11, 2022 17:04
Warning spam makes it hard to see errors in CI output. They are still useful when editing indivudal files to avoid introducing more issues and resolving existing ones gradually.
@ghost ghost force-pushed the chore/quarantine-tap-tests branch 2 times, most recently from d4279ea to 7ecd758 Compare January 11, 2022 17:18
@ghost ghost force-pushed the chore/quarantine-tap-tests branch from 7091235 to 7b7b89e Compare January 11, 2022 18:40
@ghost ghost marked this pull request as ready for review January 11, 2022 18:44
@ghost ghost requested review from a team as code owners January 11, 2022 18:44
@ghost ghost requested review from danlucian, admons and tonidevine1 January 11, 2022 18:44
@ghost ghost changed the title chore: quarantine root and system tap tests chore: quarantine tap tests Jan 11, 2022
@ghost ghost mentioned this pull request Jan 11, 2022
9 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant