Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove reachability #3588

Merged
merged 1 commit into from
Aug 15, 2022
Merged

feat: remove reachability #3588

merged 1 commit into from
Aug 15, 2022

Conversation

e102
Copy link
Contributor

@e102 e102 commented Aug 15, 2022 •
edited
Loading

removes support for reachability in the CLI

@e102 e102 self-assigned this Aug 15, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2022 •
edited
Loading

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • src/cli/args.ts
  • src/cli/commands/monitor/index.ts
  • src/lib/formatters/legacy-format-issue.ts
  • test/jest/unit/lib/formatters/remediation-based-format-issues.spec.ts
  • test/tap/cli-monitor.acceptance.test.ts

Generated by 🚫 dangerJS against 5500e25

@e102 e102 force-pushed the feat/remove-reachability branch 4 times, most recently from 832c094 to cfd1277 Compare August 15, 2022 09:18
@e102
feat: remove reachability
5500e25 
chore: remove unused package
@e102 e102 marked this pull request as ready for review August 15, 2022 10:16
@e102 e102 requested review from a team as code owners August 15, 2022 10:16
JackuB
JackuB approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@JackuB JackuB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@e102 e102 merged commit 813eb23 into master Aug 15, 2022
@e102 e102 deleted the feat/remove-reachability branch August 15, 2022 12:11
gitphill added a commit to snyk/snyk-gradle-plugin that referenced this pull request Oct 6, 2022
@gitphill
fix: remove reachability
547d91b 
Snyk CLI has removed `--reachable`.

Removing reachability and call-graph code from snyk-gradle-plugin.

See snyk/cli#3588
@gitphill gitphill mentioned this pull request Oct 6, 2022
Merged
This was referenced Oct 6, 2022
Merged
Merged
dotkas pushed a commit to snyk/snyk-gradle-plugin that referenced this pull request Nov 16, 2023
@gitphill @dotkas
fix: remove reachability
bd39674 
Snyk CLI has removed `--reachable`.

Removing reachability and call-graph code from snyk-gradle-plugin.

See snyk/cli#3588
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackuB JackuB JackuB approved these changes

@lili2311 lili2311 lili2311 approved these changes

@gitphill gitphill gitphill approved these changes

@ShiriV ShiriV ShiriV approved these changes

@jonathansantilli jonathansantilli Awaiting requested review from jonathansantilli jonathansantilli was automatically assigned from snyk/snyk-open-source

@Jdunsby Jdunsby Awaiting requested review from Jdunsby Jdunsby was automatically assigned from snyk/snyk-open-source

@robh-snyk robh-snyk Awaiting requested review from robh-snyk robh-snyk was automatically assigned from snyk/snyk-open-source

Assignees

@e102 e102

Labels
🌔 Apollo
Projects
None yet
Milestone
No milestone
5 participants
@e102 @JackuB @lili2311 @gitphill @ShiriV