Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [OSM-887] Bumping snyk-nuget-plugin for various bugfixes #4961

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

dotkas
Copy link
Contributor

@dotkas dotkas commented Dec 10, 2023

Pull Request Submission

Please check the boxes once done.

The pull request must:

  • Reviewer Documentation
    • follow CONTRIBUTING rules
    • be accompanied by a detailed description of the changes
    • contain a risk assessment of the change (Low | Medium | High) with regards to breaking existing functionality. A change e.g. of an underlying language plugin can completely break the functionality for that language, but appearing as only a version change in the dependencies.
    • highlight breaking API if applicable
    • contain a link to the automatic tests that cover the updated functionality.
    • contain testing instructions in case that the reviewer wants to manual verify as well, to add to the manual testing done by the author.
    • link to the PR for the User-facing documentation
  • User facing Documentation
    • update any relevant documentation in gitbook by submitting a gitbook PR, and including the PR link here
    • ensure that the message of the final single commit is descriptive and prefixed with either feat: or fix: , others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.
  • Testing
    • Changes, removals and additions to functionality must be covered by acceptance / integration tests or smoke tests - either already existing ones, or new ones, created by the author of the PR.

Pull Request Review

All pull requests must undergo a thorough review process before being merged.
The review process of the code PR should include code review, testing, and any necessary feedback or revisions.
Pull request reviews of functionality developed in other teams only review the given documentation and test reports.

Manual testing will not be performed by the reviewing team, and is the responsibility of the author of the PR.

For Node projects: It’s important to make sure changes in package.json are also affecting package-lock.json correctly.

If a dependency is not necessary, don’t add it.

When adding a new package as a dependency, make sure that the change is absolutely necessary. We would like to refrain from adding new dependencies when possible.
Documentation PRs in gitbook are reviewed by Snyk's content team. They will also advise on the best phrasing and structuring if needed.

Pull Request Approval

Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.

What does this PR do?

This PR bumps the version of snyk-nuget-plugin in order to solve 3 bugs related to the .NET CLI beta that's under active development, namely, it fixes:

Which all caused snyk test --dotnet-runtime-resolution to fail.

Where should the reviewer start?

For detailed investigation, see the three aforementioned PRs.

How should this be manually tested?

The nuget-app-8-windows fixture encompasses a .csproj that contains all the features that previously broke.

Any background context you want to provide?

N/A

What are the relevant tickets?

https://snyksec.atlassian.net/browse/OSM-887

@dotkas dotkas requested review from a team as code owners December 10, 2023 15:36
@dotkas dotkas force-pushed the dotkas/OSM-887/bump-nuget-plugin branch from 360cb67 to ed3ff5f Compare December 10, 2023 18:28
@dotkas dotkas force-pushed the dotkas/OSM-887/bump-nuget-plugin branch from bde6902 to 97016ea Compare December 11, 2023 12:16
@dotkas dotkas force-pushed the dotkas/OSM-887/bump-nuget-plugin branch from 97016ea to 1219b60 Compare December 11, 2023 12:17
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, but I consistently am getting timeouts that is causing the pipeline to fail.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are seeing this in the smoke tests, too. Will have a look today.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dotkas can you please disable that test for now? Somehow snyk test smoke is hanging, and even debugging doesn't give me the foggiest, why.

Copy link
Contributor

@bastiandoetsch bastiandoetsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's your risk assessment of this?

@dotkas
Copy link
Contributor Author

dotkas commented Dec 11, 2023

What's your risk assessment of this?

@bastiandoetsch it's all in beta and behind the beta argument, so I deem it low.

@dotkas dotkas enabled auto-merge (squash) December 12, 2023 07:27
@dotkas dotkas merged commit 8e896fd into master Dec 12, 2023
14 checks passed
@dotkas dotkas deleted the dotkas/OSM-887/bump-nuget-plugin branch December 12, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants