chore: don't checkout code if we have a prepared workspace #4987
Conversation
The workspace already has the code checked out, no need to do it, then overwrite it with the workspace data.
jbowes
force-pushed
the
chore/dont-checkout-with-workspace
branch
from
1e5b59c
to
ddca8c8
Compare
| @@ -758,12 +757,7 @@ jobs: | |||
| - persist_to_workspace: | |||
| root: . | |||
| paths: | |||
| - binary-releases/* | |||
There was a problem hiding this comment.
Context: We tried to optimize the runtime by being very selective when persisting the workspace. We observed performance issues on Windows runners when restoring the workspace. This is why it was more efficient to checkout the code instead of persisting it in the workspace.
There was a problem hiding this comment.
time's a wash anyways 🤷
any idea what caused the issues for windows?
There was a problem hiding this comment.
any idea what caused the issues for windows?
Unfortunately not! A wild guess would be, based on general observations on the windows runners, that they have a reduced performance when it comes to disk IO. Restoring the workspace is basically just an untar operation. Build and test duration are also not comparable to other runners.
But this is just guessing.
|
gonna delete this, it saves a few seconds on restore, but adds a few to build, so it's pretty even. |
The workspace already has the code checked out, no need to do it, then
overwrite it with the workspace data.