Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: explicitly state project version #5108

Merged

Conversation

thisislawatts
Copy link
Member

@thisislawatts thisislawatts commented Mar 12, 2024

Pull Request Submission

Please check the boxes once done.

The pull request must:

  • Reviewer Documentation
    • follow CONTRIBUTING rules
    • be accompanied by a detailed description of the changes
    • contain a risk assessment of the change (Low | Medium | High) with regards to breaking existing functionality. A change e.g. of an underlying language plugin can completely break the functionality for that language, but appearing as only a version change in the dependencies.
    • highlight breaking API if applicable
    • contain a link to the automatic tests that cover the updated functionality.
    • contain testing instructions in case that the reviewer wants to manual verify as well, to add to the manual testing done by the author.
    • link to the link to the PR for the User-facing documentation
  • User facing Documentation
    • update any relevant documentation in gitbook by submitting a gitbook PR, and including the PR link here
    • ensure that the message of the final single commit is descriptive and prefixed with either feat: or fix: , others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.
  • Testing
    • Changes, removals and additions to functionality must be covered by acceptance / integration tests or smoke tests - either already existing ones, or new ones, created by the author of the PR.

What does this PR do?

As of Composer v2.7.2 the tool will emit an error
if the version has not been defined on the root composer.json
https://github.com/composer/composer/releases/tag/2.7.2

Rather than updating the tests to expect error output we have introduced the
version property, otherwise we are relying on the fallback behaviour of Composer.

Note that relying on the default/fallback version might potentially lead to dependency resolution issues, especially when the root package depends on a package which ends up depending (directly or indirectly) back on the root package itself.
https://getcomposer.org/doc/articles/troubleshooting.md#root-package-version-detection

As of Composer v2.7.2 the tool will emit an error
if the version has not been defined on the root composer.json
https://github.com/composer/composer/releases/tag/2.7.2
@thisislawatts thisislawatts marked this pull request as ready for review March 12, 2024 10:57
@thisislawatts thisislawatts requested a review from a team as a code owner March 12, 2024 10:57
@thisislawatts thisislawatts enabled auto-merge (squash) March 12, 2024 11:03
@thisislawatts thisislawatts merged commit 1981628 into main Mar 12, 2024
14 checks passed
@thisislawatts thisislawatts deleted the test/update-composer-workspace-to-introduce-version branch March 12, 2024 11:53
MarcusArdelean pushed a commit that referenced this pull request Mar 12, 2024
As of Composer v2.7.2 the tool will emit an error
if the version has not been defined on the root composer.json
https://github.com/composer/composer/releases/tag/2.7.2
MarcusArdelean added a commit that referenced this pull request Mar 13, 2024
* fix: add support for development python versions

* test: explicitly state project version (#5108)

As of Composer v2.7.2 the tool will emit an error
if the version has not been defined on the root composer.json
https://github.com/composer/composer/releases/tag/2.7.2

* chore: introduce script to help create release (#5107)

---------

Co-authored-by: Luke Watts <luke@snyk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants