Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: introduce script to help create release #5107

Merged

Conversation

thisislawatts
Copy link
Member

@thisislawatts thisislawatts commented Mar 12, 2024

Pull Request Submission

Please check the boxes once done.

The pull request must:

  • Reviewer Documentation
    • follow CONTRIBUTING rules
    • be accompanied by a detailed description of the changes
    • contain a risk assessment of the change (Low | Medium | High) with regards to breaking existing functionality. A change e.g. of an underlying language plugin can completely break the functionality for that language, but appearing as only a version change in the dependencies.
    • highlight breaking API if applicable
    • contain a link to the automatic tests that cover the updated functionality.
    • contain testing instructions in case that the reviewer wants to manual verify as well, to add to the manual testing done by the author.
    • link to the link to the PR for the User-facing documentation
  • User facing Documentation
    • update any relevant documentation in gitbook by submitting a gitbook PR, and including the PR link here
    • ensure that the message of the final single commit is descriptive and prefixed with either feat: or fix: , others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.
  • Testing
    • Changes, removals and additions to functionality must be covered by acceptance / integration tests or smoke tests - either already existing ones, or new ones, created by the author of the PR.

Pull Request Review

All pull requests must undergo a thorough review process before being merged.
The review process of the code PR should include code review, testing, and any necessary feedback or revisions.
Pull request reviews of functionality developed in other teams only review the given documentation and test reports.

Manual testing will not be performed by the reviewing team, and is the responsibility of the author of the PR.

For Node projects: It’s important to make sure changes in package.json are also affecting package-lock.json correctly.

If a dependency is not necessary, don’t add it.

When adding a new package as a dependency, make sure that the change is absolutely necessary. We would like to refrain from adding new dependencies when possible.
Documentation PRs in gitbook are reviewed by Snyk's content team. They will also advise on the best phrasing and structuring if needed.

Pull Request Approval

Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.

What does this PR do?

Introduces a script that can be used to create a short lived branch to update the release-candidate branch ahead of a release process.

How should this be manually tested?

Run the script to verify that a new tmp/* branch is created and pushed to remote
./release-scripts/prepare-release.sh

✨ For folks with the gh CLI tool installed it will even create the PR for you.

@thisislawatts thisislawatts marked this pull request as ready for review March 12, 2024 08:59
@thisislawatts thisislawatts requested a review from a team as a code owner March 12, 2024 08:59
if command -v gh >/dev/null 2>&1; then
# Use the GitHub CLI to create a pull request
# https://cli.github.com/manual/gh_pr_create
gh pr create --repo snyk/cli --base $RC_BRANCH --title "chore: Update release candidate" --body "Release Candidate" --draft
Copy link
Member Author

@thisislawatts thisislawatts Mar 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am open to ideas for what to include on the --body

Copy link
Contributor

@j-luong j-luong Mar 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: is the PR created here exempt from the PR template?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@j-luong it will be yes if we supply a --body value.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: would it be worth following the template and using --body-file to reference the file? Although we'd have to automate filling it in.

I've no strong opinion either way, but if we wanted to include stuff in the body, that's what I'd suggest.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the value of making an automated process follow the template.

@thisislawatts thisislawatts force-pushed the chore/CLI-150-introduce-script-to-help-create-release branch from 3311b87 to d6d583c Compare March 12, 2024 12:33
@thisislawatts thisislawatts enabled auto-merge (squash) March 12, 2024 12:33
@thisislawatts thisislawatts merged commit f7eb5b4 into main Mar 12, 2024
14 checks passed
@thisislawatts thisislawatts deleted the chore/CLI-150-introduce-script-to-help-create-release branch March 12, 2024 13:26
MarcusArdelean added a commit that referenced this pull request Mar 13, 2024
* fix: add support for development python versions

* test: explicitly state project version (#5108)

As of Composer v2.7.2 the tool will emit an error
if the version has not been defined on the root composer.json
https://github.com/composer/composer/releases/tag/2.7.2

* chore: introduce script to help create release (#5107)

---------

Co-authored-by: Luke Watts <luke@snyk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants