-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: introduce script to help create release #5107
chore: introduce script to help create release #5107
Conversation
if command -v gh >/dev/null 2>&1; then | ||
# Use the GitHub CLI to create a pull request | ||
# https://cli.github.com/manual/gh_pr_create | ||
gh pr create --repo snyk/cli --base $RC_BRANCH --title "chore: Update release candidate" --body "Release Candidate" --draft |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am open to ideas for what to include on the --body
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: is the PR created here exempt from the PR template?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@j-luong it will be yes if we supply a --body
value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: would it be worth following the template and using --body-file
to reference the file? Although we'd have to automate filling it in.
I've no strong opinion either way, but if we wanted to include stuff in the body, that's what I'd suggest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the value of making an automated process follow the template.
3311b87
to
d6d583c
Compare
* fix: add support for development python versions * test: explicitly state project version (#5108) As of Composer v2.7.2 the tool will emit an error if the version has not been defined on the root composer.json https://github.com/composer/composer/releases/tag/2.7.2 * chore: introduce script to help create release (#5107) --------- Co-authored-by: Luke Watts <luke@snyk.io>
Pull Request Submission
Please check the boxes once done.
The pull request must:
feat:
orfix:
, others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.Pull Request Review
All pull requests must undergo a thorough review process before being merged.
The review process of the code PR should include code review, testing, and any necessary feedback or revisions.
Pull request reviews of functionality developed in other teams only review the given documentation and test reports.
Manual testing will not be performed by the reviewing team, and is the responsibility of the author of the PR.
For Node projects: It’s important to make sure changes in
package.json
are also affectingpackage-lock.json
correctly.If a dependency is not necessary, don’t add it.
When adding a new package as a dependency, make sure that the change is absolutely necessary. We would like to refrain from adding new dependencies when possible.
Documentation PRs in gitbook are reviewed by Snyk's content team. They will also advise on the best phrasing and structuring if needed.
Pull Request Approval
Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.
What does this PR do?
Introduces a script that can be used to create a short lived branch to update the release-candidate branch ahead of a release process.
How should this be manually tested?
Run the script to verify that a new
tmp/*
branch is created and pushed to remote./release-scripts/prepare-release.sh
✨ For folks with the
gh
CLI tool installed it will even create the PR for you.