-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(instrumentation): add trace level logging of request CLI-325 #5244
Merged
PeterSchafer
merged 1 commit into
main
from
feat/trace-level-logging-of-the-user-interaction
May 24, 2024
Merged
feat(instrumentation): add trace level logging of request CLI-325 #5244
PeterSchafer
merged 1 commit into
main
from
feat/trace-level-logging-of-the-user-interaction
May 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterSchafer
requested changes
May 17, 2024
This PR relies on changes on the go-application-framework but there are no changes to the go.mod. This means the changes will never build. please update to gaf link even if it is just a temporary commit hash, so that the CLI build can show issues. |
mgyorke
force-pushed
the
feat/trace-level-logging-of-the-user-interaction
branch
2 times, most recently
from
May 20, 2024 14:13
190b098
to
0cc3cda
Compare
mgyorke
force-pushed
the
feat/trace-level-logging-of-the-user-interaction
branch
2 times, most recently
from
May 22, 2024 09:31
0cc3cda
to
a328961
Compare
PeterSchafer
requested changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mgyorke
force-pushed
the
feat/trace-level-logging-of-the-user-interaction
branch
3 times, most recently
from
May 24, 2024 07:09
176d595
to
8d9dfe6
Compare
mgyorke
force-pushed
the
feat/trace-level-logging-of-the-user-interaction
branch
from
May 24, 2024 07:34
8d9dfe6
to
9d50e8d
Compare
PeterSchafer
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission
Please check the boxes once done.
The pull request must:
feat:
orfix:
, others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.Pull Request Review
All pull requests must undergo a thorough review process before being merged.
The review process of the code PR should include code review, testing, and any necessary feedback or revisions.
Pull request reviews of functionality developed in other teams only review the given documentation and test reports.
Manual testing will not be performed by the reviewing team, and is the responsibility of the author of the PR.
For Node projects: It’s important to make sure changes in
package.json
are also affectingpackage-lock.json
correctly.If a dependency is not necessary, don’t add it.
When adding a new package as a dependency, make sure that the change is absolutely necessary. We would like to refrain from adding new dependencies when possible.
Documentation PRs in gitbook are reviewed by Snyk's content team. They will also advise on the best phrasing and structuring if needed.
Pull Request Approval
Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.
What does this PR do?
This PR adds logging of the request at trace level.
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
What are the relevant tickets?
Screenshots
Additional questions