refactor: add types to args parser, simplify the code #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyegupov
commented
May 29, 2019
| // all arguments after a '--' are taken as is and passed to the next process | ||
| // (see the snyk-mvn-plugin or snyk-gradle-plugin) | ||
| // these agrs are split by spaces and sent as an array of strings |
There was a problem hiding this comment.
this diff is misplaced. Try using split view in github to make sense of it.
kyegupov
force-pushed
the
refactor/args-parser
branch
from
f8680e8
to
f619f9d
Compare
kyegupov
force-pushed
the
refactor/args-parser
branch
from
f619f9d
to
7d60847
Compare
lili2311
approved these changes
May 30, 2019
|
🎉 This PR is included in version 1.170.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jun 20, 2023
This was referenced Jun 20, 2023
This was referenced Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds types to the objects produced by args parser (to the extent possible),
Any background context you want to provide?
The arguments object is quite messy, this is the first step towards making it manageable.