feat: create and extend bundle [IDE-175] #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodora-sandu
force-pushed
the
feat/bundle-create
branch
2 times, most recently
from
9a7549e
to
915d7bc
Compare
This was referenced Mar 8, 2024
teodora-sandu
force-pushed
the
feat/bundle-create
branch
18 times, most recently
from
8965ede
to
e0c550c
Compare
teodora-sandu
force-pushed
the
feat/bundle-create
branch
from
e0c550c
to
5aa035b
Compare
teodora-sandu
force-pushed
the
feat/bundle-create
branch
from
0df4190
to
e6bdd3b
Compare
teodora-sandu
force-pushed
the
feat/bundle-create
branch
from
e6bdd3b
to
aa72407
Compare
teodora-sandu
changed the title
teodora-sandu
force-pushed
the
feat/bundle-create
branch
3 times, most recently
from
fec50f2
to
bddcf2d
Compare
|
The only thing not done is to include the progress tracker which is blocked by snyk/go-application-framework#130 |
teodora-sandu
force-pushed
the
feat/bundle-create
branch
from
bddcf2d
to
a6495db
Compare
scan_test.go
Outdated
| ) | ||
| } | ||
|
|
||
| func setupDocs(t *testing.T) (string, lsp.TextDocumentItem, lsp.TextDocumentItem, []byte, []byte) { |
There was a problem hiding this comment.
getting rid of the LSP stuff here should be possible :)
bastiandoetsch
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts the filtering, bundle creation, and bundle extension (upload) from
snyk-lsinto this Go library. The aim is for the new Go Snyk Code CLI to use this library too, so it needs to expose interfaces that can be used fromsnyk-lsand the CLI.Although it looks like a lot of changes, it's only because I had to move a lot of the code from
internal/topkg/in order to be able to call this library fromsnyk-lsand support dependency injection too, for easier testing.Example of how it's used in
snyk-ls: snyk/snyk-ls#455And tested it in IntelliJ too: