Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add retry for destroy on some acceptancy tests #887

Merged
merged 3 commits into from Aug 2, 2021

Conversation

moadibfr
Copy link
Contributor

No description provided.

@moadibfr moadibfr requested a review from a team as a code owner July 26, 2021 17:50
@moadibfr moadibfr marked this pull request as draft July 26, 2021 17:50
@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #887 (aadc874) into main (b734f7c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #887   +/-   ##
=======================================
  Coverage   81.59%   81.59%           
=======================================
  Files         232      232           
  Lines        7520     7520           
=======================================
  Hits         6136     6136           
  Misses       1159     1159           
  Partials      225      225           

@moadibfr moadibfr force-pushed the fea/retry_acc_test_destroy branch 2 times, most recently from 2915187 to 70025f3 Compare July 28, 2021 07:46
@moadibfr moadibfr marked this pull request as ready for review July 28, 2021 07:46
pkg/resource/aws/aws_eip_association_test.go Outdated Show resolved Hide resolved
test/acceptance/testing.go Outdated Show resolved Hide resolved
test/acceptance/testing.go Outdated Show resolved Hide resolved
test/acceptance/testing.go Outdated Show resolved Hide resolved
sundowndev
sundowndev previously approved these changes Jul 28, 2021
wbeuil
wbeuil previously approved these changes Jul 30, 2021
@moadibfr moadibfr dismissed stale reviews from wbeuil and sundowndev via 01a5718 July 30, 2021 15:27
@moadibfr moadibfr merged commit 47785e7 into main Aug 2, 2021
@moadibfr moadibfr deleted the fea/retry_acc_test_destroy branch August 2, 2021 08:26
@sundowndev sundowndev added the kind/maintenance Refactoring or changes to the workspace label Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/maintenance Refactoring or changes to the workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants