fix: stop hard failures on npm dist-tags

snyk · Jan 26, 2024 · 2501435 · 2501435
1 parent eb952ee
commit 2501435
Show file tree

Hide file tree

Showing 5 changed files with 23,310 additions and 7 deletions.
diff --git a/lib/dep-graph-builders/npm-lock-v2/index.ts b/lib/dep-graph-builders/npm-lock-v2/index.ts
@@ -359,13 +359,17 @@ export const getChildNodeKey = (
     }
 
     // So now we can check semver to filter out some values
-    const candidatePkgVersion = pkgs[candidate].version;
-    const doesVersionSatisfySemver = semver.satisfies(
-      candidatePkgVersion,
-      version,
-    );
+    // if our version is valid semver
+    if (semver.validRange(version)) {
+      const candidatePkgVersion = pkgs[candidate].version;
+      const doesVersionSatisfySemver = semver.satisfies(
+        candidatePkgVersion,
+        version,
+      );
+      return doesVersionSatisfySemver;
+    }
 
-    return doesVersionSatisfySemver;
+    return true;
   });
 
   if (filteredCandidates.length === 1) {