feat: RedHat Modules & PURLs #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommyknows
force-pushed
the
feat/rpm-modules-and-repos
branch
3 times, most recently
from
94a28fa
to
aac2ecd
Compare
tommyknows
force-pushed
the
feat/rpm-modules-and-repos
branch
from
aac2ecd
to
fe89a9c
Compare
tommyknows
force-pushed
the
feat/rpm-modules-and-repos
branch
5 times, most recently
from
503beda
to
110adb0
Compare
BREAKING CHANGE: This commit removes the RedHatRepositories fact from the returned envelope. It should be unused, so it is not expected that this breaking change would actually break something. This is in preparation for the RedHat support, where the repositories will be added to the package's `purl` fields instead.
tommyknows
force-pushed
the
feat/rpm-modules-and-repos
branch
from
110adb0
to
b08b17e
Compare
tommyknows
force-pushed
the
feat/rpm-modules-and-repos
branch
5 times, most recently
from
ab047ac
to
e5f6a51
Compare
shlomiSnyk
approved these changes
Feb 23, 2023
shlomiSnyk
requested changes
Feb 23, 2023
This commit makes use of the added PURL-support in DepGraph to include the RPM package modules as the "namespace", and the repositories as part of the qualifiers in the PURL. With this, Vuln can filter down vulnerabilities based on the repository-to-cpe mapping and also query packages by module. Support for this has been added through [Vuln #708](snyk/vuln#708).
shlomiSnyk
force-pushed
the
feat/rpm-modules-and-repos
branch
from
e5f6a51
to
ccd9c06
Compare
|
Expected release notes (by @shlomiSnyk) features: others (will not be included in Semantic-Release notes):
|
shlomiSnyk
approved these changes
Feb 23, 2023
|
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
todo
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
What are the relevant tickets?
Screenshots
Additional questions