fix docker pull issues #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When debugging issues within our Windows CI, I've noticed that `shescape` has a couple of bug fixes related to Windows. Although it turned out that `shescape` is not the issue here, I'm keeping that update in just for good measure.
So far, we've only handled errors when pulling with the Docker CLI. With the Docker CLI, we've "translated" errors to make them more helpful. The Windows tests have now started to fail because of a broken Docker installation, as we then fell back to the `snyk-docker-pull` library, which didn't have that error translation. This commit fixes that, and applies that error handling to both the CLI errors as well as errors from snyk-docker-pull.
Many may `[object Object]`s in our debug messages which are not helpful.
|
Expected release notes (by @tommyknows) features: fixes: others (will not be included in Semantic-Release notes):
|
As we noticed that the tests failed because of a broken Docker installation, we've decided to duplicate the job and run one job with a working, and one with a broken Docker CLI. This should give us some guarantee that these environments and the respective pull libraries behave the same.
tommyknows
force-pushed
the
fix-docker-pull
branch
from
132fbd5
to
21d7666
Compare
|
🎉 This PR is included in version 6.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: update shescape
When debugging issues within our Windows CI, I've noticed that
shescapehas a couple of bug fixes related to Windows. Although itturned out that
shescapeis not the issue here, I'm keeping thatupdate in just for good measure.
fix: error handling when pulling images with pull library
So far, we've only handled errors when pulling with the Docker CLI. With
the Docker CLI, we've "translated" errors to make them more helpful.
The Windows tests have now started to fail because of a broken Docker
installation, as we then fell back to the
snyk-docker-pulllibrary,which didn't have that error translation.
This commit fixes that, and applies that error handling to both the CLI
errors as well as errors from snyk-docker-pull.
fix: error messages in debugs
Many may
[object Object]s in our debug messages which are not helpful.chore: windows docker tests
As we noticed that the tests failed because of a broken Docker
installation, we've decided to duplicate the job and run one job with a
working, and one with a broken Docker CLI.
This should give us some guarantee that these environments and the
respective pull libraries behave the same.
chore: ensure Docker in CI to work