fix: validate the server URL to prevent subtle parsing effects #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go's net/url.Parse is very permissive. It's easy to pass the same "host:port" used to configure the listener as the server URL, which gets mis-interpreted as host://port, when http://host:port was intended. This adds strict validation to the server URL, preventing this kind of subtle bug from creating much confusion when the validator then fails to match any paths and everything 404s.
genslein
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go's net/url.Parse is very permissive. It's easy to pass the same
"host:port" used to configure the listener as the server URL, which gets
mis-interpreted as host://port, when http://host:port was intended.
This adds strict validation to the server URL, preventing this kind of
subtle bug from creating much confusion when the validator then fails to
match any paths and everything 404s.